Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 52b154a911f1b2450d8d73569b70599a6b6e9974
https://github.com/WebKit/WebKit/commit/52b154a911f1b2450d8d73569b70599a6b6e9974
Author: Timothy Hatcher <[email protected]>
Date: 2023-12-18 (Mon, 18 Dec 2023)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm
Log Message:
-----------
TestWebKitAPI.WKWebExtensionAPITabs.ActiveTab is flaky.
https://webkit.org/b/266594
rdar://119346255
Reviewed by Brian Weinstein.
The URL does not change for tabs during the provisional load, and saying it was
changing
was causing the onChanged event to fire too soon for this test to be accurate.
Also tweak how we check for properties in the changeInfo object to be
consistent.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(-[TestWebExtensionTab webView:didStartProvisionalNavigation:]):
(-[TestWebExtensionTab
webView:didReceiveServerRedirectForProvisionalNavigation:]):
(-[TestWebExtensionTab webView:didFailNavigation:withError:]):
Canonical link: https://commits.webkit.org/272240@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
