Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0345820aee4313ca1a9ec8f7d9e77ebe92c7dd4c
https://github.com/WebKit/WebKit/commit/0345820aee4313ca1a9ec8f7d9e77ebe92c7dd4c
Author: Charlie Wolfe <[email protected]>
Date: 2023-12-18 (Mon, 18 Dec 2023)
Changed paths:
M Source/WebCore/page/EventHandler.cpp
M Source/WebKit/Shared/WebEventConversion.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/VerifyUserGestureFromUIProcess.mm
Log Message:
-----------
Verifying user gestures doesn’t work when opening a window on a key event
https://bugs.webkit.org/show_bug.cgi?id=266590
rdar://119826688
Reviewed by Pascoe.
We weren’t passing the authorization token to `UserGestureIndicator` and it was
lost when converting
the event to a platform key event.
Also remove a redundant call to `recordUserGestureAuthorizationToken()`. It’s
called in `sendKeyEvent()`
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent):
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleKeyboardEvent):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/VerifyUserGestureFromUIProcess.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/272246@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
