Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 74ebfc4e9b84e6c61b5d272b480d1f61d2a12398
https://github.com/WebKit/WebKit/commit/74ebfc4e9b84e6c61b5d272b480d1f61d2a12398
Author: Alan Baradlay <[email protected]>
Date: 2024-01-03 (Wed, 03 Jan 2024)
Changed paths:
M
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
M
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h
Log Message:
-----------
[IFC][Cleanup] Variable names should reflect whether they are logical or
visual
https://bugs.webkit.org/show_bug.cgi?id=267018
Reviewed by Antti Koivisto.
We normally deal with logical coords in layout and mix them with visual coords
only at display content construction.
This patch makes it clear whether a local variable holds logical or visual
coords.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
Let's just pass in LineBox at construction time so that we don't have to pass
it around in InlineDisplayContentBuilder.
(WebCore::Layout::InlineFormattingContext::createDisplayContentForInlineContent):
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::InlineDisplayContentBuilder):
(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendSoftLineBreakDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendHardLineBreakDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendAtomicInlineLevelDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendRootInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineDisplayBoxAtBidiBoundary):
(WebCore::Layout::InlineDisplayContentBuilder::insertRubyAnnotationBox):
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes):
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
(WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes):
(WebCore::Layout::InlineDisplayContentBuilder::lineBox const):
(WebCore::Layout::InlineDisplayContentBuilder::lineIndex const):
(WebCore::Layout::InlineDisplayContentBuilder::rootStyle const):
*
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::baseEndAdditionalLogicalWidth):
(WebCore::Layout::RubyFormattingContext::placeAnnotationBox):
(WebCore::Layout::RubyFormattingContext::sizeAnnotationBox):
(WebCore::Layout::RubyFormattingContext::baseEndAdditionalVisualWidth): Deleted.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:
Canonical link: https://commits.webkit.org/272609@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
