Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f72d16287b1b22b75a471b272346ff74ab298fa4
https://github.com/WebKit/WebKit/commit/f72d16287b1b22b75a471b272346ff74ab298fa4
Author: Tim Nguyen <[email protected]>
Date: 2024-01-06 (Sat, 06 Jan 2024)
Changed paths:
R LayoutTests/fast/css/pseudo-class-internal-expected.txt
R LayoutTests/fast/css/pseudo-class-internal.html
A
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos.html
M Source/WebCore/css/CSSPseudoSelectors.json
M Source/WebCore/css/html.css
M Source/WebCore/css/process-css-pseudo-selectors.py
M Source/WebCore/html/TextFieldInputType.cpp
Log Message:
-----------
Make `::-webkit-loading-auto-fill-button` an internal pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=267169
rdar://120579213
Reviewed by Darin Adler.
This was added (relatively) recently in 252146@main in 2022 so it should be
safe to unexpose.
Additional reasons the risk of compat fallout is low are:
- There are no hits on Github currently
- There are no hits on Apple's code search site as well
- ::-webkit- prefixed pseudo-elements have special parsing quirks for
compatibility so they do not disable declarations if unrecognized
(see selectors specification: https://drafts.csswg.org/selectors-4/#compat)
* LayoutTests/fast/css/pseudo-class-internal-expected.txt: Removed.
* LayoutTests/fast/css/pseudo-class-internal.html: Removed.
*
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos.html:
Added.
Add tests and remove obsolete one.
* Source/WebCore/css/CSSPseudoSelectors.json: Rename pseudo.
* Source/WebCore/css/html.css: Rename usages.
(input::-internal-loading-auto-fill-button):
(input::-webkit-loading-auto-fill-button): Deleted.
* Source/WebCore/css/process-css-pseudo-selectors.py:
Fix a bug in code generation where it was generating this invalid code:
if (!context.mode == UASheetMode && ...)
Wrap the condition inside parentheses to prevent that.
* Source/WebCore/html/TextFieldInputType.cpp: Use new UserAgentPartId
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):
Canonical link: https://commits.webkit.org/272736@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
