Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 118818edb0786cb6eb2301c265881019ea29b576
https://github.com/WebKit/WebKit/commit/118818edb0786cb6eb2301c265881019ea29b576
Author: Youenn Fablet <[email protected]>
Date: 2024-01-09 (Tue, 09 Jan 2024)
Changed paths:
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h
Log Message:
-----------
webrtc/datachannel/multiple-connections.html is sometimes timing out after
M120 upgrade
https://bugs.webkit.org/show_bug.cgi?id=267281
rdar://problem/120725671
Reviewed by Eric Carlson.
We were sometimes deadlocking when:
- main thread asks something to the webrtc stack by hopping to the signalling
thread.
- signaling thread is destroying the LibWebRTCAudioModule which was calling
callOnMainThreadAndWait to do its cleanup.
Instead of cleaning things in LibWebRTCAudioModule destructor synchronsouly, we
are doing the clean-up asynchronously in LibWebRTCAudioModule::Terminate.
Setting m_logTimer to nullptr there is fine since m_logTimer is used in
Start/Stop via callOnMainThread.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:
(WebCore::LibWebRTCAudioModule::~LibWebRTCAudioModule):
(WebCore::LibWebRTCAudioModule::Terminate):
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:
Canonical link: https://commits.webkit.org/272828@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
