Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f1b26b939f9dc33b507fdb601c65cb518e3c6b59
https://github.com/WebKit/WebKit/commit/f1b26b939f9dc33b507fdb601c65cb518e3c6b59
Author: Ryosuke Niwa <[email protected]>
Date: 2024-01-23 (Tue, 23 Jan 2024)
Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/editing/FrameSelection.cpp
Log Message:
-----------
Document::Document shouldn't construct Editor object
https://bugs.webkit.org/show_bug.cgi?id=267901
Reviewed by Yusuke Suzuki and Cameron McCormack.
Don't create Editor object inside Document::Document. This was getting
triggered via
shouldAlwaysUseDirectionalSelection inside FrameSelection::FrameSelection.
Also added a bunch of assertions to ensure we don't initialize these lazily
constructed
objects at the end of Document::Document.
* Source/WebCore/dom/Document.cpp:
(WebCore::m_frameIdentifier):
(WebCore::Document::ensureQuirks):
(WebCore::Document::ensureCachedResourceLoader):
(WebCore::Document::ensureExtensionStyleSheets):
(WebCore::Document::ensureMarkers):
(WebCore::Document::ensureVisitedLinkState):
(WebCore::Document::ensureFullscreenManager):
(WebCore::Document::fontLoader):
(WebCore::Document::ensureFontLoader):
(WebCore::Document::ensureFontSelector):
(WebCore::Document::ensureUndoManager):
(WebCore::Document::ensureEditor):
(WebCore::Document::ensureReportingScope):
(WebCore::Document::originIdentifierForPasteboard const):
(WebCore::Document::isDNSPrefetchEnabled const):
(WebCore::Document::parseDNSPrefetchControlHeader):
* Source/WebCore/dom/Document.h:
(WebCore::Document::isDNSPrefetchEnabled const): Deleted.
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::shouldAlwaysUseDirectionalSelection):
Canonical link: https://commits.webkit.org/273350@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
