Title: [110222] trunk/Source/WebCore
- Revision
- 110222
- Author
- [email protected]
- Date
- 2012-03-08 15:35:15 -0800 (Thu, 08 Mar 2012)
Log Message
[V8] Use EventNames instead of strings
https://bugs.webkit.org/show_bug.cgi?id=80649
Reviewed by Ojan Vafai.
No new tests. Covered by existing tests.
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (110221 => 110222)
--- trunk/Source/WebCore/ChangeLog 2012-03-08 23:32:01 UTC (rev 110221)
+++ trunk/Source/WebCore/ChangeLog 2012-03-08 23:35:15 UTC (rev 110222)
@@ -1,3 +1,15 @@
+2012-03-08 Erik Arvidsson <[email protected]>
+
+ [V8] Use EventNames instead of strings
+ https://bugs.webkit.org/show_bug.cgi?id=80649
+
+ Reviewed by Ojan Vafai.
+
+ No new tests. Covered by existing tests.
+
+ * bindings/v8/V8AbstractEventListener.cpp:
+ (WebCore::V8AbstractEventListener::invokeEventHandler):
+
2012-03-08 Tim Horton <[email protected]>
No-op filter changes color output because of colorspace issues
Modified: trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.cpp (110221 => 110222)
--- trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.cpp 2012-03-08 23:32:01 UTC (rev 110221)
+++ trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.cpp 2012-03-08 23:35:15 UTC (rev 110222)
@@ -34,6 +34,7 @@
#include "DateExtension.h"
#include "Document.h"
#include "Event.h"
+#include "EventNames.h"
#include "Frame.h"
#include "InspectorCounters.h"
#include "V8Binding.h"
@@ -140,7 +141,7 @@
v8::Local<v8::Value> returnValue;
// In beforeunload/unload handlers, we want to avoid sleeps which do tight loops of calling Date.getTime().
- if (event->type() == "beforeunload" || event->type() == "unload")
+ if (event->type() == eventNames().beforeunloadEvent || event->type() == eventNames().unloadEvent)
DateExtension::get()->setAllowSleep(false);
{
@@ -177,7 +178,7 @@
tryCatch.Reset();
}
- if (event->type() == "beforeunload" || event->type() == "unload")
+ if (event->type() == eventNames().beforeunloadEvent || event->type() == eventNames().unloadEvent)
DateExtension::get()->setAllowSleep(true);
ASSERT(!V8Proxy::handleOutOfMemory() || returnValue.IsEmpty());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
