Title: [110230] trunk/Source/WebKit/blackberry
Revision
110230
Author
[email protected]
Date
2012-03-08 16:31:40 -0800 (Thu, 08 Mar 2012)

Log Message

[BlackBerry] Always use the current focused node when processing focus changes
https://bugs.webkit.org/show_bug.cgi?id=80594

Patch by Mike Fenton <[email protected]> on 2012-03-08
Reviewed by Antonio Gomes.

Guard against toRange or fromRange being null when called
as part of a clear event.

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (110229 => 110230)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-03-09 00:19:40 UTC (rev 110229)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-03-09 00:31:40 UTC (rev 110230)
@@ -1,3 +1,16 @@
+2012-03-08  Mike Fenton  <[email protected]>
+
+        [BlackBerry] Always use the current focused node when processing focus changes
+        https://bugs.webkit.org/show_bug.cgi?id=80594
+
+        Reviewed by Antonio Gomes.
+
+        Guard against toRange or fromRange being null when called
+        as part of a clear event.
+
+        * WebCoreSupport/EditorClientBlackBerry.cpp:
+        (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
+
 2012-03-08  Yong Li  <[email protected]>
 
         [BlackBerry] Block file-to-file access by default

Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp (110229 => 110230)


--- trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp	2012-03-09 00:19:40 UTC (rev 110229)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp	2012-03-09 00:31:40 UTC (rev 110230)
@@ -194,7 +194,7 @@
             return false;
 
         // Check if this change does not represent a focus change and input is active and if so ensure the keyboard is visible.
-        if (m_webPagePrivate->m_inputHandler->isInputMode() && (fromRange->startContainer() == toRange->startContainer()))
+        if (m_webPagePrivate->m_inputHandler->isInputMode() && fromRange && toRange && (fromRange->startContainer() == toRange->startContainer()))
             m_webPagePrivate->m_inputHandler->notifyClientOfKeyboardVisibilityChange(true);
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to