Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e54b6b08878139eb460ad1094980014450c5e5b8
https://github.com/WebKit/WebKit/commit/e54b6b08878139eb460ad1094980014450c5e5b8
Author: Xabier Rodriguez-Calvar <[email protected]>
Date: 2024-02-02 (Fri, 02 Feb 2024)
Changed paths:
M LayoutTests/media/media-controller-play-then-pause-expected.txt
M LayoutTests/media/media-controller-play-then-pause.html
A
LayoutTests/media/media-source/media-controller-media-source-play-then-pause-expected.txt
A
LayoutTests/media/media-source/media-controller-media-source-play-then-pause.html
A LayoutTests/media/media-source/media-source-seek-and-play-expected.txt
A LayoutTests/media/media-source/media-source-seek-and-play.html
A LayoutTests/media/media-source/media-source-video-seek-pause-expected.txt
A LayoutTests/media/media-source/media-source-video-seek-pause.html
A LayoutTests/media/video-seek-pause-expected.txt
A LayoutTests/media/video-seek-pause.html
M LayoutTests/media/video-test.js
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
M
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
M
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
[MSE][GStreamer] Pause after seek is not working
https://bugs.webkit.org/show_bug.cgi?id=263317
Reviewed by Philippe Normand.
When issuing seeks and play or pauses close to each other, there can be race
conditions. To solve then first we need to
avoid changing the pipeline state while seeking. Then we need to ensure we know
if the pipeline change was rejected or
failed, so the function signature was changed. We also need to consider that
when a pause is requested by the element
and the player issues it to the pipeline, we are paused because it can take
some time for the pipeline to pause and if
the element queries too fast, it can lead to more race conditions.
* LayoutTests/media/media-controller-play-then-pause-expected.txt:
* LayoutTests/media/media-controller-play-then-pause.html:
*
LayoutTests/media/media-source/media-controller-media-source-play-then-pause-expected.txt:
Added.
*
LayoutTests/media/media-source/media-controller-media-source-play-then-pause.html:
Added.
* LayoutTests/media/media-source/media-source-seek-and-play-expected.txt: Added.
* LayoutTests/media/media-source/media-source-seek-and-play.html: Added.
* LayoutTests/media/media-source/media-source-video-seek-pause-expected.txt:
Added.
* LayoutTests/media/media-source/media-source-video-seek-pause.html: Added.
* LayoutTests/media/video-seek-pause-expected.txt: Added.
* LayoutTests/media/video-seek-pause.html: Added.
* LayoutTests/media/video-test.js:
(return.new.Promise):
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::isPipelineSeeking const):
(WebCore::MediaPlayerPrivateGStreamer::play):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::paused const):
(WebCore::MediaPlayerPrivateGStreamer::seekToTarget):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
*
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):
*
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::isPlayerPaused const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Canonical link: https://commits.webkit.org/273977@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
