Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 13769cf1e65593750d931d505723cda7c2e3874d
https://github.com/WebKit/WebKit/commit/13769cf1e65593750d931d505723cda7c2e3874d
Author: Jeff Miller <[email protected]>
Date: 2024-02-03 (Sat, 03 Feb 2024)
Changed paths:
M Source/WebCore/rendering/HitTestResult.h
M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h
M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm
M Source/WebKit/Shared/WebHitTestResultData.cpp
M Source/WebKit/Shared/WebHitTestResultData.h
M Source/WebKit/Shared/WebHitTestResultData.serialization.in
M Source/WebKit/UIProcess/API/APIHitTestResult.h
M Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm
Log Message:
-----------
_WKHitTestResult should expose an imageSuggestedFilename property
https://bugs.webkit.org/show_bug.cgi?id=268588
rdar://122130871
Reviewed by Aditya Keerthi.
Add hasEntireImage and imageSuggestedFilename to WebHitTestResultData (and the
underlying plumbing
to support calculating the filename) and expose imageSuggestedFilename via a
property on
_WKHitTestResult. hasEntireImage is currently exposed on
_WKContextMenuElementInfo, which in
hindsight was probably a mistake, it should be on _WKHitTestResult since that
class contains every
other related property, but I'll address that in a separate patch.
* Source/WebCore/rendering/HitTestResult.h:
Export hasEntireImage() so WebKit can use it.
* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h:
Added imageSuggestedFilename property.
* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm:
(-[_WKHitTestResult imageSuggestedFilename]):
Added.
* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::imageSuggestedFilenameFromHitTestResult):
Added, we can only determine the suggested filename if the entire image is
available.
(WebKit::WebHitTestResultData::WebHitTestResultData):
Initialize linkLocalDataMIMEType.
* Source/WebKit/Shared/WebHitTestResultData.h:
Added imageSuggestedFilename and hasEntireImage.
* Source/WebKit/Shared/WebHitTestResultData.serialization.in:
Ditto.
* Source/WebKit/UIProcess/API/APIHitTestResult.h:
(API::HitTestResult::imageSuggestedFilename const):
Added.
* Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm:
(TestWebKitAPI::TEST):
Added HitTestResultImageSuggestedFilename, loads an image and verifies that the
imageSuggestedFilename is the name of the file.
Canonical link: https://commits.webkit.org/274042@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
