Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0aa3d40bc28f2e815c92c9ec6a4c1fc841e22609
https://github.com/WebKit/WebKit/commit/0aa3d40bc28f2e815c92c9ec6a4c1fc841e22609
Author: Alan Baradlay <[email protected]>
Date: 2024-02-03 (Sat, 03 Feb 2024)
Changed paths:
M
LayoutTests/fast/inline/text-decoration-underline-inline-box-offset-expected.html
M LayoutTests/fast/inline/text-decoration-underline-inline-box-offset.html
M Source/WebCore/style/InlineTextBoxStyle.cpp
Log Message:
-----------
[Painting] Default gap is only used by computedUnderlineOffset
https://bugs.webkit.org/show_bug.cgi?id=268692
Reviewed by Antti Koivisto.
This is in preparation for adding text-underline left/right painting support.
Remove defaultGap from UnderlineOffsetArguments struct and instead call the
helper function directly from computedUnderlineOffset (only place where it is
used)
(test case change: let's go back to the initial test case with Ahem font now.
The test update had incorrect assumptions about what was being tested here.)
* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::defaultGap):
(WebCore::computedUnderlineOffset):
(WebCore::visualOverflowForDecorations):
(WebCore::underlineOffsetForTextBoxPainting):
Canonical link: https://commits.webkit.org/274055@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
