Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ffedc5fb9606192a9b87137b74788c6efa93d70
https://github.com/WebKit/WebKit/commit/5ffedc5fb9606192a9b87137b74788c6efa93d70
Author: Simon Fraser <[email protected]>
Date: 2024-02-03 (Sat, 03 Feb 2024)
Changed paths:
M Source/WebCore/page/scrolling/ScrollingTree.cpp
M Source/WebCore/page/scrolling/ScrollingTree.h
M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm
M
Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp
M
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp
M Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp
Log Message:
-----------
Clarify the role of "mainFrameCanRubberBand" at the ScrollingTree level
https://bugs.webkit.org/show_bug.cgi?id=268697
rdar://122242780
Reviewed by Tim Horton.
ScrollingTree::mainFrameCanRubberBandOnSide() is easy to mis-use: it doesn't
mean that rubber-banding
will happen, only that the client (Safari, Mail etc) has allowed rubber-banding
to happen on this side.
So rename it accordingly.
This make it clear that
`ScrollingTreeScrollingNodeDelegateMac::shouldRubberBandOnSide()` isn't
using it correctly. Future changes will fix that.
* Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::setClientAllowedMainFrameRubberBandableEdges):
(WebCore::ScrollingTree::clientAllowsMainFrameRubberBandingOnSide):
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
(WebCore::ScrollingTree::setMainFrameCanRubberBand): Deleted.
(WebCore::ScrollingTree::mainFrameCanRubberBandOnSide): Deleted.
* Source/WebCore/page/scrolling/ScrollingTree.h:
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::shouldRubberBandOnSide const):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::handleWheelEvent):
*
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp:
(WebKit::RemoteLayerTreeEventDispatcher::determineWheelEventProcessing):
* Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::internalWheelEvent):
Canonical link: https://commits.webkit.org/274061@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
