Title: [110328] trunk/Source/WebCore
- Revision
- 110328
- Author
- [email protected]
- Date
- 2012-03-09 13:50:24 -0800 (Fri, 09 Mar 2012)
Log Message
[V8] Undo text position adjustment for attribute event handlers
https://bugs.webkit.org/show_bug.cgi?id=80725
Reviewed by Adam Barth.
No new tests. Needs rebaseline.
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (110327 => 110328)
--- trunk/Source/WebCore/ChangeLog 2012-03-09 21:34:44 UTC (rev 110327)
+++ trunk/Source/WebCore/ChangeLog 2012-03-09 21:50:24 UTC (rev 110328)
@@ -1,3 +1,15 @@
+2012-03-09 Erik Arvidsson <[email protected]>
+
+ [V8] Undo text position adjustment for attribute event handlers
+ https://bugs.webkit.org/show_bug.cgi?id=80725
+
+ Reviewed by Adam Barth.
+
+ No new tests. Needs rebaseline.
+
+ * bindings/v8/V8LazyEventListener.cpp:
+ (WebCore::V8LazyEventListener::prepareListenerObject):
+
2012-03-09 Tom Sepez <[email protected]>
Hold cached images with a CachedResourceHandle rather than a raw pointer for CSSCrossfadeValue
Modified: trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp (110327 => 110328)
--- trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp 2012-03-09 21:34:44 UTC (rev 110327)
+++ trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp 2012-03-09 21:50:24 UTC (rev 110328)
@@ -146,17 +146,12 @@
code.append("return function(");
code.append(m_eventParameterName);
code.append(") {");
-
- int codePrexixLength = code.length();
-
code.append(m_code);
// Insert '\n' otherwise //-style comments could break the handler.
code.append("\n};}}}})");
v8::Handle<v8::String> codeExternalString = v8ExternalString(code);
- TextPosition adjustedPosition(m_position.m_line, OrdinalNumber::fromZeroBasedInt(m_position.m_column.zeroBasedInt() - codePrexixLength));
-
- v8::Handle<v8::Script> script = V8Proxy::compileScript(codeExternalString, m_sourceURL, adjustedPosition);
+ v8::Handle<v8::Script> script = V8Proxy::compileScript(codeExternalString, m_sourceURL, m_position);
if (script.IsEmpty())
return;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
