Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4e820e51d023639ce378712eb3f6640e8db7fe02
https://github.com/WebKit/WebKit/commit/4e820e51d023639ce378712eb3f6640e8db7fe02
Author: Mike Wyrzykowski <[email protected]>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/WebGPU/WebGPU/RenderPipeline.mm
M Source/WebGPU/WebGPU/ShaderModule.h
M Source/WebGPU/WebGPU/ShaderModule.mm
M Source/WebGPU/WebGPU/Texture.mm
Log Message:
-----------
[WebGPU] usesFeature should be considered on an entry point basis
https://bugs.webkit.org/show_bug.cgi?id=269091
<radar://122666801>
Reviewed by Dan Glastonbury.
Previously we considered if an entire shader module used
a feature on a global basis.
This is incorrect as it should only matter if the entry
point uses a specific feature.
Correct this by storing usesFeature per entry point.
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::errorValidatingInterstageShaderInterfaces):
(WebGPU::Device::createRenderPipeline):
* Source/WebGPU/WebGPU/ShaderModule.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::parseFragmentReturnType):
(WebGPU::ShaderModule::shaderModuleState const):
(WebGPU::ShaderModule::populateShaderModuleState):
(WebGPU::ShaderModule::usesFrontFacingInInput const):
(WebGPU::ShaderModule::usesSampleIndexInInput const):
(WebGPU::ShaderModule::usesSampleMaskInInput const):
(WebGPU::ShaderModule::usesSampleMaskInOutput const):
(WebGPU::ShaderModule::usesFragDepth const):
(WebGPU::ShaderModule::populateFragmentInputs):
(WebGPU::ShaderModule::parseFragmentInputs):
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::parseFragmentReturnType): Deleted.
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::errorValidatingImageCopyTexture):
Canonical link: https://commits.webkit.org/274474@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
