Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fa850bc9a68cedc60740b89dd3aadc436431f8f4
https://github.com/WebKit/WebKit/commit/fa850bc9a68cedc60740b89dd3aadc436431f8f4
Author: Alex Christensen <[email protected]>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/editing/DictionaryPopupInfo.h
M Source/WebCore/editing/cocoa/DictionaryLookup.mm
M Source/WebCore/editing/mac/DictionaryLookup.h
R Source/WebCore/editing/mac/DictionaryLookupLegacy.mm
M Source/WebCore/page/cocoa/EventHandlerCocoa.mm
M Source/WebCore/testing/Internals.mm
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.h
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.h
M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm
Log Message:
-----------
Remove DictionaryLookupLegacy and associated NSDictionary piping
https://bugs.webkit.org/show_bug.cgi?id=269248
rdar://122837616
Reviewed by Megan Gardner.
DictionaryLookupLegacy is dead code that is not compiled anywhere.
It is also the only source of the NSDictionary "options" that is sent
to the UI process, then nothing is done with it. Remove all that.
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/editing/DictionaryPopupInfo.h:
* Source/WebCore/editing/cocoa/DictionaryLookup.mm:
(WebCore::DictionaryLookup::rangeForSelection):
(WebCore::DictionaryLookup::rangeAtHitTestResult):
(WebCore::DictionaryLookup::stringForPDFSelection):
(): Deleted.
* Source/WebCore/editing/mac/DictionaryLookup.h:
* Source/WebCore/editing/mac/DictionaryLookupLegacy.mm: Removed.
* Source/WebCore/page/cocoa/EventHandlerCocoa.mm:
(WebCore::EventHandler::selectClosestWordFromHitTestResultBasedOnLookup):
* Source/WebCore/testing/Internals.mm:
(WebCore::Internals::rangeForDictionaryLookupAtLocation):
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit:: const):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit:: const):
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit:: const):
* Source/WebKit/WebProcess/Plugins/PluginView.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::WebPage::dictionaryPopupInfoForRange):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin):
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
(WebKit::WebPage::lookupTextAtLocation):
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
* Source/WebKitLegacy/mac/WebView/WebImmediateActionController.h:
* Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm:
(+[WebImmediateActionController
_dictionaryPopupInfoForRange:inFrame:indicatorOptions:transition:]):
(-[WebImmediateActionController _animationControllerForText]):
(+[WebImmediateActionController
_dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
Deleted.
Canonical link: https://commits.webkit.org/274520@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
