Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fbda7ba402cf38ffcee77d7bd120bd4e9213f85f
https://github.com/WebKit/WebKit/commit/fbda7ba402cf38ffcee77d7bd120bd4e9213f85f
Author: Charlie Wolfe <[email protected]>
Date: 2024-02-15 (Thu, 15 Feb 2024)
Changed paths:
M Source/WebKit/Shared/ContextMenuContextData.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Log Message:
-----------
[Site Isolation] Context menu is offset in iframes
https://bugs.webkit.org/show_bug.cgi?id=269437
rdar://122994262
Reviewed by Alex Christensen.
The context menu is offset when clicked in an iframe because an iframe process
is trying to convert to
root view coordinates. To convert to root view coordinates from an iframe
process we need to convert
from each parent root frame.
* Source/WebKit/Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::setMenuLocation):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setTextIndicatorFromFrame):
(WebKit::WebPageProxy::showContextMenuFromFrame):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::remoteViewToRootView):
(WebKit::WebPage::remoteViewRectToRootView):
(WebKit::WebPage::remoteViewPointToRootView):
(WebKit::WebPage::remoteViewCoordinatesToRootView): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Canonical link: https://commits.webkit.org/274761@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
