Title: [110380] trunk
- Revision
- 110380
- Author
- [email protected]
- Date
- 2012-03-10 10:21:56 -0800 (Sat, 10 Mar 2012)
Log Message
RenderObject with 'resize' different from 'none' should have a RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80738
Reviewed by James Robinson.
Source/WebCore:
Covered by fast/css/resize-single-axis.html.
* rendering/RenderBox.h:
(WebCore::RenderBox::requiresLayerForOverflowClip):
The resizer logic is tied to RenderLayer so force a RenderLayer to be allocated if resize() != RESIZE_NONE.
LayoutTests:
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/win/Skipped:
Unskip the test on most platform but Qt. Qt has a bug about the test timing out
which may be related.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (110379 => 110380)
--- trunk/LayoutTests/ChangeLog 2012-03-10 17:38:42 UTC (rev 110379)
+++ trunk/LayoutTests/ChangeLog 2012-03-10 18:21:56 UTC (rev 110380)
@@ -1,3 +1,18 @@
+2012-03-10 Julien Chaffraix <[email protected]>
+
+ RenderObject with 'resize' different from 'none' should have a RenderLayer
+ https://bugs.webkit.org/show_bug.cgi?id=80738
+
+ Reviewed by James Robinson.
+
+ * platform/chromium/test_expectations.txt:
+ * platform/efl/test_expectations.txt:
+ * platform/gtk/test_expectations.txt:
+ * platform/mac/test_expectations.txt:
+ * platform/win/Skipped:
+ Unskip the test on most platform but Qt. Qt has a bug about the test timing out
+ which may be related.
+
2012-03-10 Nikolas Zimmermann <[email protected]>
Not reviewed. Final chunk of SL rebaselines with Generic RGB profile for svg/.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110379 => 110380)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-10 17:38:42 UTC (rev 110379)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-10 18:21:56 UTC (rev 110380)
@@ -3837,7 +3837,6 @@
// Those tests need a text baseline after lazily allocating layers.
// The change should only be layer removal.
-BUGWK75568 : fast/css/resize-single-axis.html = TEXT
BUGWK75568 : compositing/geometry/object-clip-rects-assertion.html = TEXT
BUGWK75568 : compositing/overflow/ancestor-overflow.html = IMAGE PASS
BUGWK75568 : fast/events/mouse-relative-position.html = TEXT
Modified: trunk/LayoutTests/platform/efl/test_expectations.txt (110379 => 110380)
--- trunk/LayoutTests/platform/efl/test_expectations.txt 2012-03-10 17:38:42 UTC (rev 110379)
+++ trunk/LayoutTests/platform/efl/test_expectations.txt 2012-03-10 18:21:56 UTC (rev 110380)
@@ -60,7 +60,6 @@
BUGWK75568 : fast/css/invalidation-errors.html = TEXT
BUGWK75568 : fast/css/line-height.html = TEXT
BUGWK75568 : fast/css/nested-layers-with-hover.html = TEXT
-BUGWK75568 : fast/css/resize-single-axis.html = TEXT
BUGWK75568 : fast/css/text-input-with-webkit-border-radius.html = TEXT
BUGWK75568 : fast/dom/isindex-001.html = TEXT
BUGWK75568 : fast/dom/isindex-002.html = TEXT
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (110379 => 110380)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-03-10 17:38:42 UTC (rev 110379)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-03-10 18:21:56 UTC (rev 110380)
@@ -173,7 +173,6 @@
BUGWK75568 : fast/css/invalidation-errors.html = TEXT
BUGWK75568 : fast/css/line-height.html = TEXT
BUGWK75568 : fast/css/nested-layers-with-hover.html = TEXT
-BUGWK75568 : fast/css/resize-single-axis.html = TEXT
BUGWK75568 : fast/css/text-input-with-webkit-border-radius.html = TEXT
BUGWK75568 : fast/css/text-overflow-input.html = TEXT
BUGWK75568 : fast/dom/isindex-001.html = TEXT
Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (110379 => 110380)
--- trunk/LayoutTests/platform/mac/test_expectations.txt 2012-03-10 17:38:42 UTC (rev 110379)
+++ trunk/LayoutTests/platform/mac/test_expectations.txt 2012-03-10 18:21:56 UTC (rev 110380)
@@ -274,7 +274,6 @@
BUGWK75568 : fast/css/invalidation-errors.html = TEXT
BUGWK75568 : fast/css/line-height.html = TEXT
BUGWK75568 : fast/css/nested-layers-with-hover.html = TEXT
-BUGWK75568 : fast/css/resize-single-axis.html = TEXT
BUGWK75568 : fast/css/text-input-with-webkit-border-radius.html = TEXT
BUGWK75568 : fast/css/text-overflow-input.html = TEXT
BUGWK75568 : fast/dom/isindex-001.html = TEXT
Modified: trunk/LayoutTests/platform/win/Skipped (110379 => 110380)
--- trunk/LayoutTests/platform/win/Skipped 2012-03-10 17:38:42 UTC (rev 110379)
+++ trunk/LayoutTests/platform/win/Skipped 2012-03-10 18:21:56 UTC (rev 110380)
@@ -1723,7 +1723,6 @@
fast/css/invalidation-errors.html
fast/css/line-height.html
fast/css/nested-layers-with-hover.html
-fast/css/resize-single-axis.html
fast/css/text-input-with-webkit-border-radius.html
fast/css/text-overflow-input.html
fast/dom/isindex-001.html
Modified: trunk/Source/WebCore/ChangeLog (110379 => 110380)
--- trunk/Source/WebCore/ChangeLog 2012-03-10 17:38:42 UTC (rev 110379)
+++ trunk/Source/WebCore/ChangeLog 2012-03-10 18:21:56 UTC (rev 110380)
@@ -1,3 +1,16 @@
+2012-03-10 Julien Chaffraix <[email protected]>
+
+ RenderObject with 'resize' different from 'none' should have a RenderLayer
+ https://bugs.webkit.org/show_bug.cgi?id=80738
+
+ Reviewed by James Robinson.
+
+ Covered by fast/css/resize-single-axis.html.
+
+ * rendering/RenderBox.h:
+ (WebCore::RenderBox::requiresLayerForOverflowClip):
+ The resizer logic is tied to RenderLayer so force a RenderLayer to be allocated if resize() != RESIZE_NONE.
+
2012-03-10 Stephen White <[email protected]>
Unreviewed, rolling out r110358.
Modified: trunk/Source/WebCore/rendering/RenderBox.h (110379 => 110380)
--- trunk/Source/WebCore/rendering/RenderBox.h 2012-03-10 17:38:42 UTC (rev 110379)
+++ trunk/Source/WebCore/rendering/RenderBox.h 2012-03-10 18:21:56 UTC (rev 110380)
@@ -616,6 +616,10 @@
if (!hasOverflowClip())
return false;
+ // The resizer is attached to the RenderLayer so we need one.
+ if (style()->resize() != RESIZE_NONE)
+ return true;
+
// FIXME: overflow: auto could also lazily create its layer but some repainting
// issues are arising from that.
bool _onlyOverflowHidden_ = style()->overflowX() == OHIDDEN && style()->overflowY() == OHIDDEN;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
