Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c7ecac1db21bec1e86214988a146ecd119be54b2
https://github.com/WebKit/WebKit/commit/c7ecac1db21bec1e86214988a146ecd119be54b2
Author: David Kilzer <ddkil...@apple.com>
Date: 2024-02-16 (Fri, 16 Feb 2024)
Changed paths:
M Source/WebCore/PAL/pal/ios/UIKitSoftLink.mm
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h
M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h
M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm
A Source/WebKit/Shared/Cocoa/CoreIPCNSShadow.h
A Source/WebKit/Shared/Cocoa/CoreIPCNSShadow.mm
A Source/WebKit/Shared/Cocoa/CoreIPCNSShadow.serialization.in
M Source/WebKit/Shared/Cocoa/CoreIPCTypes.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
Log Message:
-----------
Generate serialization of NSShadow
https://bugs.webkit.org/show_bug.cgi?id=268963
<rdar://107553244>
Reviewed by Brady Eidson.
* Source/WebCore/PAL/pal/ios/UIKitSoftLink.mm:
- Export PAL::getNSShadowClass() for use in WebKit.
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
- Add CoreIPCNSShadow.serialization.in.
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h:
- Add predeclaration for NSShadow class.
- Add NSShadow to enum class NSType.
(IPC::getClass<PlatformColor>): Add.
(IPC::getClass<NSShadow>): Add.
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::getClass<PlatformColor>): Add.
- Provide method to get UIColor.class since it's soft-linked on
non-AppKit platforms.
(IPC::getClass<NSShadow>): Add.
- Provide method to get NSShadow.class since it's soft-linked on
non-AppKit platforms.
(IPC::typeFromObject):
- Switch from WebCore::CocoaColor to PlatformColorClass.
- Update to handle NSShadow.
(IPC::shouldEnableStrictMode):
- Remove reference to NSShadow.
* Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h:
* Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm:
(WebKit::valueFromID):
- Add CoreIPCNSShadow.
* Source/WebKit/Shared/Cocoa/CoreIPCNSShadow.h: Copied from
Source/WebKit/Shared/Cocoa/CoreIPCTypes.h.
(WebKit::CoreIPCNSShadow::CoreIPCNSShadow):
* Source/WebKit/Shared/Cocoa/CoreIPCNSShadow.mm: Copied from
Source/WebKit/Shared/Cocoa/CoreIPCTypes.h.
(WebKit::CoreIPCNSShadow::CoreIPCNSShadow):
(WebKit::CoreIPCNSShadow::toID const):
* Source/WebKit/Shared/Cocoa/CoreIPCNSShadow.serialization.in: Added.
* Source/WebKit/Shared/Cocoa/CoreIPCTypes.h:
- Include CoreIPCNSShadow.h.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Add CoreIPCNSShadow.* files to the project.
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(ObjCHolderForTesting::encode const):
- Add RetainPtr<NSShadow> to variant for testing.
(runTestNS):
(runTestCFWithExpectedResult):
(runTestCF):
- Change lambdas to static functions so we could start to break apart
the IPC.Serialization.Basic test, which is way too big.
(TEST(IPCSerialization, Basic)):
- Move lambdas out of of this test function.
(TEST(IPCSerialization, NSShadow)): Add.
- Test serialization of NSShadow.
(TEST(IPCSerialization, SecureCoding)):
- Remove duplicate runTestNS lambda.
Canonical link: https://commits.webkit.org/274870@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
