Title: [110402] trunk/Source/WebCore
- Revision
- 110402
- Author
- [email protected]
- Date
- 2012-03-11 17:40:43 -0700 (Sun, 11 Mar 2012)
Log Message
Fix a crash opening the Web Inspector in WebKit1 clients.
The call to InspectorFrontendClientLocal::setAttachedWindow is preformed really early in the process,
causing it to crash almost every time. It should use evaluateOnLoad instead of evaluateAsBoolean.
<rdar://problem/10951109> Crash when bringing up Web Inspector in WebKit1 client
https://bugs.webkit.org/show_bug.cgi?id=80796
Reviewed by Brian Weinstein.
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Use evaluateOnLoad instead of evaluateAsBoolean.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (110401 => 110402)
--- trunk/Source/WebCore/ChangeLog 2012-03-11 22:17:36 UTC (rev 110401)
+++ trunk/Source/WebCore/ChangeLog 2012-03-12 00:40:43 UTC (rev 110402)
@@ -1,3 +1,18 @@
+2012-03-11 Timothy Hatcher <[email protected]>
+
+ Fix a crash opening the Web Inspector in WebKit1 clients.
+
+ The call to InspectorFrontendClientLocal::setAttachedWindow is preformed really early in the process,
+ causing it to crash almost every time. It should use evaluateOnLoad instead of evaluateAsBoolean.
+
+ <rdar://problem/10951109> Crash when bringing up Web Inspector in WebKit1 client
+ https://bugs.webkit.org/show_bug.cgi?id=80796
+
+ Reviewed by Brian Weinstein.
+
+ * inspector/InspectorFrontendClientLocal.cpp:
+ (WebCore::InspectorFrontendClientLocal::setAttachedWindow): Use evaluateOnLoad instead of evaluateAsBoolean.
+
2012-03-11 Shawn Singh <[email protected]>
REGRESSION (r93614): scrolling div does not repaint
Modified: trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp (110401 => 110402)
--- trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp 2012-03-11 22:17:36 UTC (rev 110401)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp 2012-03-12 00:40:43 UTC (rev 110402)
@@ -211,7 +211,7 @@
void InspectorFrontendClientLocal::setAttachedWindow(bool attached)
{
- evaluateAsBoolean(String::format("InspectorFrontendAPI.setAttachedWindow(%s)", attached ? "true" : "false"));
+ evaluateOnLoad(String::format("[\"setAttachedWindow\", %s]", attached ? "true" : "false"));
}
void InspectorFrontendClientLocal::restoreAttachedWindowHeight()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
