Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be2916dac989bfb95ddfe2acb75c9631f1d00959 https://github.com/WebKit/WebKit/commit/be2916dac989bfb95ddfe2acb75c9631f1d00959 Author: Pascoe <pas...@apple.com> Date: 2024-02-28 (Wed, 28 Feb 2024)
Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: ----------- [WebAuthn] Overrelease in error for multi-origin credentials rdar://123357813 https://bugs.webkit.org/show_bug.cgi?id=269942 Reviewed by Chris Dumez. There's evidence for crashes being caused by the over-release of the dictionary inside userInfo[NSUnderlyingErrorKey] for the error returned for multi-origin credentials. This patch is to use RetainPtr in WebKit for this dictionary. I have not been able to reproduce the crash, so this is speculative. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::performRequest): Canonical link: https://commits.webkit.org/275466@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes