Title: [110456] trunk
Revision
110456
Author
[email protected]
Date
2012-03-12 12:24:45 -0700 (Mon, 12 Mar 2012)

Log Message

Fix regression on fast/table/table-row-compositing-repaint-crash.html
https://bugs.webkit.org/show_bug.cgi?id=80804

Reviewed by Simon Fraser.

Covered by existing tests.

http://trac.webkit.org/changeset/110401/ accidentally caused
fast/table/table-row-compositing-repaint-crash.html to fail.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):

Modified Paths

Diff

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110455 => 110456)


--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-12 19:20:56 UTC (rev 110455)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-03-12 19:24:45 UTC (rev 110456)
@@ -3937,7 +3937,6 @@
 BUGABARTH SNOWLEOPARD : fast/events/input-image-scrolled-x-y.html = PASS CRASH
 
 BUGWK80801 : fast/js/function-constructor-error.html = TEXT
-BUGWK80804 DEBUG : fast/table/table-row-compositing-repaint-crash.html = CRASH
 
 BUGWK80807 MAC : fast/events/invalid-001.html = PASS CRASH
 BUGWK80807 MAC : fast/events/invalid-002.html = PASS CRASH

Modified: trunk/LayoutTests/platform/qt/Skipped (110455 => 110456)


--- trunk/LayoutTests/platform/qt/Skipped	2012-03-12 19:20:56 UTC (rev 110455)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-03-12 19:24:45 UTC (rev 110456)
@@ -2740,7 +2740,3 @@
 # https://bugs.webkit.org/show_bug.cgi?id=75568
 plugins/mouse-click-plugin-clears-selection.html
 fast/events/mouse-relative-position.html
-
-# [Qt] REGRESSION(r110401): fast/table/table-row-compositing-repaint-crash.html asserts
-# https://bugs.webkit.org/show_bug.cgi?id=80833
-fast/table/table-row-compositing-repaint-crash.html

Modified: trunk/Source/WebCore/ChangeLog (110455 => 110456)


--- trunk/Source/WebCore/ChangeLog	2012-03-12 19:20:56 UTC (rev 110455)
+++ trunk/Source/WebCore/ChangeLog	2012-03-12 19:24:45 UTC (rev 110456)
@@ -1,3 +1,18 @@
+2012-03-11  Shawn Singh  <[email protected]>
+
+        Fix regression on fast/table/table-row-compositing-repaint-crash.html
+        https://bugs.webkit.org/show_bug.cgi?id=80804
+
+        Reviewed by Simon Fraser.
+
+        Covered by existing tests.
+
+        http://trac.webkit.org/changeset/110401/ accidentally caused
+        fast/table/table-row-compositing-repaint-crash.html to fail.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::updateBacking):
+
 2012-03-12  Mike Lawther  <[email protected]>
 
         CSS3 calc: enable mixed percent/absolute for font

Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (110455 => 110456)


--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2012-03-12 19:20:56 UTC (rev 110455)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2012-03-12 19:24:45 UTC (rev 110456)
@@ -420,7 +420,8 @@
             // The RenderLayer's needs to update repaint rects here, because the target
             // repaintContainer may have changed after becoming a composited layer.
             // https://bugs.webkit.org/show_bug.cgi?id=80641
-            layer->computeRepaintRects();
+            if (layer->parent())
+                layer->computeRepaintRects();
 
 #if PLATFORM(MAC) && USE(CA)
             Settings* settings = m_renderView->document()->settings();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to