Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c557c381299f4792c24a527e2728fead11b391f5
      
https://github.com/WebKit/WebKit/commit/c557c381299f4792c24a527e2728fead11b391f5
  Author: Youenn Fablet <[email protected]>
  Date:   2024-03-07 (Thu, 07 Mar 2024)

  Changed paths:
    M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

  Log Message:
  -----------
  Screen share / getDisplayMedia() buggy behavior and usability issues
https://bugs.webkit.org/show_bug.cgi?id=269961
rdar://123492622

Reviewed by Eric Carlson.

The default width and height if not set are 1920x1080, which might not align 
with the actual window/screen sizes.
This triggers adding black pixels to preserve the aspect ratio.
If width and height are not provided, we use SCContentFilter contentRect 
information to fill width and height.

Manually tested for both window and screen capture.
This does not yet the case of window size changing, this will be done as a 
follow-up.

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::streamConfiguration):

Canonical link: https://commits.webkit.org/275789@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to