Branch: refs/heads/safari-7618.1.15.14-branch
Home: https://github.com/WebKit/WebKit
Commit: 2d60069b2bedbc97ecb5c3bf1891698399b7b8e1
https://github.com/WebKit/WebKit/commit/2d60069b2bedbc97ecb5c3bf1891698399b7b8e1
Author: Russell Epstein <[email protected]>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7618.1.15.14.1
Identifier: [email protected]
Commit: 31e01f5bb3b0e69e711aa408f62557cf74943d59
https://github.com/WebKit/WebKit/commit/31e01f5bb3b0e69e711aa408f62557cf74943d59
Author: Kimmo Kinnunen <[email protected]>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M
LayoutTests/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt
M
LayoutTests/platform/ios/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
Log Message:
-----------
Cherry-pick 26aaa25dcbdc. rdar://122309325
REGRESSION(267824@main): Changing HTMLCanvasElement width, height causes
intermediate buffer allocations
https://bugs.webkit.org/show_bug.cgi?id=268745
rdar://122309325
Reviewed by Simon Fraser.
Resizing is intended to leave the buffer unallocated, so that
sequential width, height assignments will not allocate multiple times.
This intention was nullified by CanvasRenderingContext2DBase::reset().
Calling resetTransform redundantly would recreate the buffer
immediately from width, height attribute setters.
The transform reset is redundant, the context transform is reset when
the context state saver is restored and re-saved.
Clearing the canvas doesn't need to use public
CanvasRenderingContext2DBase::clearCanvas() that will mutate the context
state. The state is in known state with initial transform, and thus it
doesn't need transform mutation.
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::reset):
Canonical link: https://commits.webkit.org/274135@main
Identifier: [email protected]
Commit: 1d38857f5d9007f5c47d6d6ddc0b35856bb2d430
https://github.com/WebKit/WebKit/commit/1d38857f5d9007f5c47d6d6ddc0b35856bb2d430
Author: Ben Nham <[email protected]>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
Log Message:
-----------
Cherry-pick f4ce57789de5. rdar://121185956
hideContentUntilPendingUpdate async IPC call during backgrounding blocks
process suspension
https://bugs.webkit.org/show_bug.cgi?id=268799
rdar://121185956
Reviewed by Chris Dumez.
On iOS, when the UIProcess goes into the background, it eventually calls in
to
hideContentUntilPendingUpdate through this call stack:
```
WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate()
WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground()
WebKit::ApplicationStateTracker::didCompleteSnapshotSequence()
```
The problem is that we recently added an async
`DrawingArea::DispatchAfterEnsuringDrawing` IPC with
reply handler call to hideContentUntilPendingUpdate (see 269776@main,
270672@main, 271260@main). An
async IPC with a reply handler in the UIProcess implicitly takes out a
background activity which
prevents the WebContent process (and also the UIProcess) from suspending
until the reply handler
runs. Unfortunately, since the WebContent process is in the background,
presumably it doesn't
render, so the DispatchAfterEnsuringDrawing reply handler doesn't run, and
the background activity
also never completes. We basically end up blocking process suspension
entirely until the 15 second
timer in ProcessStateMonitor expires and forcefully invalidates all
background activities for all
processes.
We need to fix this by reworking the logic somehow or by making this
DispatchAfterEnsuringDrawing
IPC not create a background activity. Here I'm just trying to make the IPC
call not start a
background activity.
Note that there's also a DispatchAfterEnsuringDrawing call in WebPageProxy
that I didn't touch since
I don't have evidence that it's causing a background power regression, but
I wonder if that also
should avoid creating a background activity.
*
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate):
Canonical link: https://commits.webkit.org/274157@main
Identifier: [email protected]
Commit: c4a7c5823ba73e8980db9a1e601e100d262e2049
https://github.com/WebKit/WebKit/commit/c4a7c5823ba73e8980db9a1e601e100d262e2049
Author: Jer Noble <[email protected]>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
A
LayoutTests/http/tests/media/fairplay/fps-mse-multi-key-renewal-expected.txt
A LayoutTests/http/tests/media/fairplay/fps-mse-multi-key-renewal.html
M
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
Log Message:
-----------
Cherry-pick 8c14e2cb8214. rdar://121931039
[Cocoa] Netflix.com key renewal fails, causes playback errors, stuttering.
https://bugs.webkit.org/show_bug.cgi?id=268830
rdar://121931039
Reviewed by Andy Estes.
When adding a workaround for a platform change in behavior in the modern
AVContentKeySession path,
a behavior was introduced which narrowly affects the way Netflix.com
preloads keys. Previously,
a "renew" message would result in the resulting AVContentKeyRequest
replacing the entire set of
pre-loaded keys from the previous request, some of which were in use by
Netflix.
Rather than replace the entire set, replace only the AVContentKeyRequest
within the batch of requests
whose contentKeySpecifier has a maching identifier to the replacement.
*
LayoutTests/http/tests/media/fairplay/fps-mse-multi-key-renewal-expected.txt:
Added.
* LayoutTests/http/tests/media/fairplay/fps-mse-multi-key-renewal.html:
Added.
*
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
Canonical link: https://commits.webkit.org/274172@main
Identifier: [email protected]
Commit: 03cf3773e47c6128563da24bd51fd7105af04be5
https://github.com/WebKit/WebKit/commit/03cf3773e47c6128563da24bd51fd7105af04be5
Author: Tim Horton <[email protected]>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
Log Message:
-----------
Cherry-pick da1f44819e66. rdar://121400620
REGRESSION: Google search results are cropped when viewing in the smallest
window size
https://bugs.webkit.org/show_bug.cgi?id=268845
rdar://121400620
Reviewed by Aditya Keerthi.
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _isWindowResizingEnabled]):
_enhancedWindowingEnabled was recently flipped on (which is correct), but
caused
some unexpected viewport regressions on visionOS. To maintain the status
quo,
override it to NO for the time being.
Canonical link: https://commits.webkit.org/274173@main
Identifier: [email protected]
Commit: 931e309eb1eb1baaf3dbd750006c0f894820a185
https://github.com/WebKit/WebKit/commit/931e309eb1eb1baaf3dbd750006c0f894820a185
Author: Brent Fulgham <[email protected]>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
Log Message:
-----------
Cherry-pick c710e9dd3240. rdar://121414876
Add Spotify to the desktop class quirks list
https://bugs.webkit.org/show_bug.cgi?id=268928
<rdar://121414876>
Reviewed by Wenson Hsieh and Chris Dumez.
It is nearly impossible to use the volume control or playback scrubber
in Spotify in Safari. They don't expect a desktop with touch support.
Spotify removed the scrubber features on iOS back in 2016
(https://community.spotify.com/t5/iOS-iPhone-iPad/Audio-scrubber-is-gone-in-latest-update-Why/td-p/1311946
This patch presents Safari to Spotify as a mobile User Agent so that we
get the best "touch" version of the website.
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::desktopClassBrowsingRecommendedForRequest):
Canonical link: https://commits.webkit.org/274268@main
Identifier: [email protected]
Commit: 2c104c4a2ee25cf4f7fe53cbe4b2af8cd81174d5
https://github.com/WebKit/WebKit/commit/2c104c4a2ee25cf4f7fe53cbe4b2af8cd81174d5
Author: Aditya Keerthi <[email protected]>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
Log Message:
-----------
Cherry-pick db96b72c4ad3. rdar://121572842
[visionOS] Safari can become unresponsive to pinches/gestures after exiting
fullscreen
https://bugs.webkit.org/show_bug.cgi?id=268970
rdar://121572842
Reviewed by Wenson Hsieh.
Hit-test redirection is applied by the system whenever a view controller
with
a custom presentation style, such as WebKit's fullscreen view controller, is
presented.
Unlike on iOS, WebKit does not explicitly dismiss the view controller, since
window hiding is used for the exit transition. In most cases, this is fine,
since the `UIWindow` will also be deallocated on exit. However, there is no
guarantee that `UIWindow` deallocation will occur, and its object lifetime
cannot be relied upon for correctness. In this case, the system will still
attempt to redirect hit-testing to the presented view controller.
Consequently,
pinches and gestures may get redirected to a hidden view controller, rather
than the visible Safari window, resulting in unresponsiveness.
Fix by explicitly dismissing the presented view controller on fullscreen
exit.
In the longer term, hit-test redirection logic should be updated by the
system,
to avoid hidden windows. However, as that is a riskier change, and
dismissing
the fullscreen view controller is good cleanup, that is the immediate
solution.
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController
_performSpatialFullScreenTransition:completionHandler:]):
Canonical link: https://commits.webkit.org/274309@main
Identifier: [email protected]
Commit: b4d974e578219e219683e62a416bfd0a0f56cc8f
https://github.com/WebKit/WebKit/commit/b4d974e578219e219683e62a416bfd0a0f56cc8f
Author: Russell Epstein <[email protected]>
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
Log Message:
-----------
Revert "Cherry-pick f4ce57789de5. rdar://121185956"
This reverts commit 1d38857f5d9007f5c47d6d6ddc0b35856bb2d430.
Identifier: [email protected]
Commit: c2875c820dadfe74a6245b50ccb6150ff683d47e
https://github.com/WebKit/WebKit/commit/c2875c820dadfe74a6245b50ccb6150ff683d47e
Author: Russell Epstein <[email protected]>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7618.1.15.14.2
Canonical link: https://commits.webkit.org/[email protected]
Commit: b8784833d650d02e2bb0224048bb5cac40988138
https://github.com/WebKit/WebKit/commit/b8784833d650d02e2bb0224048bb5cac40988138
Author: Tim Horton <[email protected]>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/graphics/ImageBuffer.h
M Source/WebCore/platform/graphics/ImageBufferBackend.h
M Source/WebCore/platform/graphics/cocoa/IOSurface.h
A Source/WebCore/platform/graphics/re/DynamicContentScalingResourceCache.h
A Source/WebCore/platform/graphics/re/DynamicContentScalingResourceCache.mm
M
Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingBifurcatedImageBuffer.mm
M
Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingImageBufferBackend.mm
M
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.h
M
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm
Log Message:
-----------
Cherry-pick 03a60be8929d. rdar://122127093
REGRESSION (271770@main): visionOS: Significant regression on MotionMark
https://bugs.webkit.org/show_bug.cgi?id=269010
rdar://122127093
Reviewed by Simon Fraser.
Before 271770@main, the dynamic content scaling image buffer was a sidecar,
outside
of the normal flow of the front/back buffer swapping. After that commit, it
was moved
inside the main image buffer, and thus is swapped like the base scale
rendering.
This had one unintended consequence: when we're discarding the back buffer
(e.g. because it contains an IOSurface that is still in-use and can't be
recycled),
we will now *also* discard the dynamic content scaling image buffer, and,
critically,
its resource cache.
The whole point of the resource cache is to maintain state between frames,
so this is
wildly counterproductive. Once you get into a state where you are discarding
back buffers (which comes up frequently under load, like MotionMark),
you're also
losing all resource caching.
Instead of trying to rearchitect the discarding code to avoid dropping the
display
list image buffer, just maintain the dynamic content scaling resource cache
in a sidecar on the RemoteLayerBackingStore, like it was before, and pass it
down to the image buffer.
A subsequent patch will make a similar change for the remote rendering case.
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/cocoa/IOSurface.h:
* Source/WebCore/platform/graphics/re/DynamicContentScalingResourceCache.h:
Added.
(WebCore::DynamicContentScalingResourceCache::DynamicContentScalingResourceCache):
*
Source/WebCore/platform/graphics/re/DynamicContentScalingResourceCache.mm:
Added.
(WebCore::DynamicContentScalingResourceCache::create):
*
Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingBifurcatedImageBuffer.mm:
*
Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingImageBufferBackend.mm:
*
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.h:
*
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm:
(WebKit::RemoteLayerWithInProcessRenderingBackingStore::ensureDynamicContentScalingResourceCache):
(WebKit::RemoteLayerWithInProcessRenderingBackingStore::allocateBuffer):
(WebKit::RemoteLayerWithInProcessRenderingBackingStore::allocateBuffer
const): Deleted.
* Source/WebCore/platform/graphics/ImageBuffer.h:
* Source/WebCore/platform/graphics/ImageBufferBackend.h:
Note that it is not safe in a unified-sources world to forward-declare
WebCore::IOSurface
because of the name conflict with ::IOSurface; we need to strictly order
the declarations,
which is easiest to achieve by just importing our header.
Canonical link: https://commits.webkit.org/274319@main
Identifier: [email protected]
Commit: e11828222a51572c18061844614460d24c3bf0c8
https://github.com/WebKit/WebKit/commit/e11828222a51572c18061844614460d24c3bf0c8
Author: Alan Baradlay <[email protected]>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
A
LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width-expected.html
A
LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width.html
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
Log Message:
-----------
Cherry-pick 06f1371ababe. rdar://122586549
[IFC][Ruby] Text are clipped at the bottom on some pages with ruby in Books
https://bugs.webkit.org/show_bug.cgi?id=269079
<rdar://122586549>
Reviewed by Antti Koivisto.
Take ruby width adjustment (annotation box is wider than base content) into
account when non-trivial line breaking requires us to rebuild the current line.
*
LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width-expected.html:
Added.
*
LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width.html:
Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::rebuildLineWithInlineContent): This is the
exact copy of what we do in candidateContentForLine when collecting the content
for current line.
Canonical link: https://commits.webkit.org/274387@main
Identifier: [email protected]
Commit: 2ec902830458a815bbe678135bb106667c447799
https://github.com/WebKit/WebKit/commit/2ec902830458a815bbe678135bb106667c447799
Author: Myah Cobbs <[email protected]>
Date: 2024-02-09 (Fri, 09 Feb 2024)
Changed paths:
M Source/WebKit/NetworkProcess/NetworkSession.h
M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
M
Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
Log Message:
-----------
Cherry-pick eb352590aabe. rdar://122361008
Identifier: [email protected]
Commit: 96f31d945d14bc68dc2acef4146dacddd94b5ec8
https://github.com/WebKit/WebKit/commit/96f31d945d14bc68dc2acef4146dacddd94b5ec8
Author: Dan Robson <[email protected]>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.14.3
Identifier: [email protected]
Commit: 5016ec9faa34736e60c9dc31d62d5be22363dd6c
https://github.com/WebKit/WebKit/commit/5016ec9faa34736e60c9dc31d62d5be22363dd6c
Author: Alan Baradlay <[email protected]>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
A
LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap-expected.html
A LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap.html
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
Log Message:
-----------
Cherry-pick 9f3eab39f42a. rdar://122501121
[IFC][Ruby] Some characters are overlapped (Hiragana + Kanji character with
Ruby)
https://bugs.webkit.org/show_bug.cgi?id=269064
<rdar://122501121>
Reviewed by Antti Koivisto.
1. When annotation is wide than the base content, we slightly pull adjacent
content under the annotation on both sides
2. Pulling the "after" content (boxes to the right of the ruby) means
shifting all the runs as one monolithic content.
However in case of justified alignment, as we are supposed to keep the
spacing intact, we only adjust the adjacent run
by moving and expanding it (expanding ensure the rest of the "after"
content stays stationary).
*
LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap-expected.html:
Added.
* LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap.html:
Added.
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):
Canonical link: https://commits.webkit.org/274373@main
Identifier: [email protected]
Commit: e4d0dee051cd8c89eb06517277fa8fba28f40de7
https://github.com/WebKit/WebKit/commit/e4d0dee051cd8c89eb06517277fa8fba28f40de7
Author: Ryosuke Niwa <[email protected]>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/WebCore/dom/ContainerNodeAlgorithms.cpp
M Source/WebCore/html/HTMLFormControlElement.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLObjectElement.cpp
M Source/WebCore/html/ValidatedFormListedElement.cpp
M Source/WebCore/svg/SVGFEImageElement.cpp
M Source/WebCore/svg/SVGTextPathElement.cpp
Log Message:
-----------
Cherry-pick 980a1d5fec28. rdar://121612950
Restrict didFinishInsertingNode to connected nodes
https://bugs.webkit.org/show_bug.cgi?id=268051
Reviewed by Wenson Hsieh.
Don't call didFinishInsertingNode when a node is not connected to a
document.
* Source/WebCore/dom/ContainerNodeAlgorithms.cpp:
(WebCore::notifyNodeInsertedIntoTree):
(WebCore::notifyChildNodeInserted):
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedIntoAncestor):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedIntoAncestor):
* Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp:
(WebCore::HTMLMaybeFormAssociatedCustomElement::insertedIntoAncestor):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedIntoAncestor):
* Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedIntoAncestor):
* Source/WebCore/html/ValidatedFormListedElement.cpp:
(WebCore::ValidatedFormListedElement::insertedIntoAncestor): Call
resetFormOwner when this insertion
didn't result in getting connected to a new document since
didFinishInsertingNode won't be called in
such cases. It's okay to call this function synchronously in this case
since we don't rely on
TreeScope::getElementById when the node is not connected to a a document in
findAssociatedForm.
* Source/WebCore/svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedIntoAncestor):
* Source/WebCore/svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedIntoAncestor):
Canonical link: https://commits.webkit.org/273523@main
Identifier: [email protected]
Commit: f6b6e7ae652bed5a152d7e921761417f0b2fbce6
https://github.com/WebKit/WebKit/commit/f6b6e7ae652bed5a152d7e921761417f0b2fbce6
Author: Joshua Hoffman <[email protected]>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
Log Message:
-----------
Cherry-pick 58895edc47c1. rdar://122778867
AX: Missing _prepareAccessibilityCall in
accessibilityIsInNonNativeTextControl
https://bugs.webkit.org/show_bug.cgi?id=269214
rdar://122778867
Reviewed by Andres Gonzalez.
We need to add a _prepareAccessibilityCall to avoid a nullptr dereference.
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityIsInNonNativeTextControl]):
Canonical link: https://commits.webkit.org/274497@main
Identifier: [email protected]
Commit: 5b0eda76984839d3ea6372ec10f14df0922572a8
https://github.com/WebKit/WebKit/commit/5b0eda76984839d3ea6372ec10f14df0922572a8
Author: Jer Noble <[email protected]>
Date: 2024-02-12 (Mon, 12 Feb 2024)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
M
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
Log Message:
-----------
Cherry-pick 56b164c3ab85. rdar://122444388
REGRESSION(272969@main): Null-deref crash in
SourceBufferPrivateAVFObjC::trackDidChangeEnabled
https://bugs.webkit.org/show_bug.cgi?id=268921
rdar://122444388
Reviewed by Eric Carlson.
The WebAVSampleBufferListener m_listener is invalidated and destroyed in
SourceBufferPrivateAVFObjC::destroyRenderers(),
and is never recreated. It is subsequently used without nil-checking the
next time a renderer is recreated. Rather than
destroying and re-creating whenever renderers are destroyed and created,
make it a Ref<> object whose lifetime is the same
(or longer) as the object which owns it.
*
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
*
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
Canonical link: https://commits.webkit.org/274323@main
Identifier: [email protected]
Commit: 47cfa3693e28c75b67f70819e49b47cbc8303af4
https://github.com/WebKit/WebKit/commit/47cfa3693e28c75b67f70819e49b47cbc8303af4
Author: Myah Cobbs <[email protected]>
Date: 2024-02-13 (Tue, 13 Feb 2024)
Changed paths:
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
Log Message:
-----------
Revert "Cherry-pick 58895edc47c1. rdar://122778867"
This reverts commit f6b6e7ae652bed5a152d7e921761417f0b2fbce6.
Identifier: [email protected]
Commit: 58f1cf841e8e6cda8a371e934e75cfdf87f32e46
https://github.com/WebKit/WebKit/commit/58f1cf841e8e6cda8a371e934e75cfdf87f32e46
Author: Myah Cobbs <[email protected]>
Date: 2024-02-13 (Tue, 13 Feb 2024)
Changed paths:
M Source/WebCore/dom/ContainerNodeAlgorithms.cpp
M Source/WebCore/html/HTMLFormControlElement.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLObjectElement.cpp
M Source/WebCore/html/ValidatedFormListedElement.cpp
M Source/WebCore/svg/SVGFEImageElement.cpp
M Source/WebCore/svg/SVGTextPathElement.cpp
Log Message:
-----------
Revert "Cherry-pick 980a1d5fec28. rdar://121612950"
This reverts commit e4d0dee051cd8c89eb06517277fa8fba28f40de7.
Identifier: [email protected]
Commit: 67d888338a78a9a56c44f1d379f31c91906d6098
https://github.com/WebKit/WebKit/commit/67d888338a78a9a56c44f1d379f31c91906d6098
Author: Myah Cobbs <[email protected]>
Date: 2024-02-13 (Tue, 13 Feb 2024)
Changed paths:
R
LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap-expected.html
R LayoutTests/fast/ruby/ruby-overhang-with-justified-content-overlap.html
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
Log Message:
-----------
Revert "Cherry-pick 9f3eab39f42a. rdar://122501121"
This reverts commit 5016ec9faa34736e60c9dc31d62d5be22363dd6c.
Identifier: [email protected]
Commit: 18b458ffca0e307738a2b919a04ba6c3f55b3354
https://github.com/WebKit/WebKit/commit/18b458ffca0e307738a2b919a04ba6c3f55b3354
Author: Dan Robson <[email protected]>
Date: 2024-02-14 (Wed, 14 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.14.4
Canonical link: https://commits.webkit.org/[email protected]
Commit: 2cce8526360d8e790a1285f9323eb1e9a5aaeeec
https://github.com/WebKit/WebKit/commit/2cce8526360d8e790a1285f9323eb1e9a5aaeeec
Author: Sihui Liu <[email protected]>
Date: 2024-02-14 (Wed, 14 Feb 2024)
Changed paths:
M Source/WebCore/page/Quirks.cpp
Log Message:
-----------
Cherry-pick 31136601a244. rdar://122892811
Null pointer dereference in elementHasClassInClosestAncestors
https://bugs.webkit.org/show_bug.cgi?id=269308
rdar://122892811
Reviewed by Brent Fulgham.
Ensure ancestor is non-null before accessing it.
* Source/WebCore/page/Quirks.cpp:
(WebCore::elementHasClassInClosestAncestors):
Canonical link: https://commits.webkit.org/274575@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: a0d2642b5329d745743e7e01c036f8b25d8307a8
https://github.com/WebKit/WebKit/commit/a0d2642b5329d745743e7e01c036f8b25d8307a8
Author: Justin Michaud <[email protected]>
Date: 2024-02-15 (Thu, 15 Feb 2024)
Changed paths:
M Source/JavaScriptCore/Scripts/process-entitlements.sh
Log Message:
-----------
Cherry-pick 8179ae2db1bf. rdar://122826926
Clean up JSC shell entitlements to fix RAMificaton.
rdar://122826926
Reviewed by Yusuke Suzuki.
In https://commits.webkit.org/272448.472@safari-7618-branch, we switched
to the new allow-jit entitlement. This broke RAMiciation runs because
the JSC binary doesn't have the
com.apple.developer.web-browser-engine.webcontent
entitlement. This patch adds it.
* Source/JavaScriptCore/Scripts/process-entitlements.sh:
Canonical link: https://commits.webkit.org/272448.538@safari-7618-branch
Identifier: [email protected]
Commit: f375eabe691c7b81bd2b44059d1b762ba6925c10
https://github.com/WebKit/WebKit/commit/f375eabe691c7b81bd2b44059d1b762ba6925c10
Author: Dan Robson <[email protected]>
Date: 2024-02-19 (Mon, 19 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.14.5
Identifier: [email protected]
Commit: e91286bdc08bcc1fb2c1192df26867872680beb6
https://github.com/WebKit/WebKit/commit/e91286bdc08bcc1fb2c1192df26867872680beb6
Author: Dan Robson <[email protected]>
Date: 2024-02-19 (Mon, 19 Feb 2024)
Changed paths:
M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
M
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.h
M
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.mm
M
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Log Message:
-----------
Apply patch. rdar://123126872
Identifier: [email protected]
Commit: 06eafcf941f0d309a87786564184e18d15abf922
https://github.com/WebKit/WebKit/commit/06eafcf941f0d309a87786564184e18d15abf922
Author: Garrett Davidson <[email protected]>
Date: 2024-02-19 (Mon, 19 Feb 2024)
Changed paths:
M
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Log Message:
-----------
Cherry-pick 1d32f0c70849. rdar://123241173
Add some missing null checks for WebAuthn extension options
rdar://123161979
Reviewed by Brent Fulgham.
Add some missing null checks for WebAuthn extension options.
*
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::WebAuthenticatorCoordinatorProxy::requestsForRegisteration):
(WebKit::WebAuthenticatorCoordinatorProxy::requestsForAssertion):
Canonical link: https://commits.webkit.org/274952@main
Identifier: [email protected]
Commit: a6b53430144aa01513ecfab5f17ebe056eb69b70
https://github.com/WebKit/WebKit/commit/a6b53430144aa01513ecfab5f17ebe056eb69b70
Author: Dan Robson <[email protected]>
Date: 2024-02-20 (Tue, 20 Feb 2024)
Changed paths:
M LayoutTests/platform/ios/TestExpectations
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
Log Message:
-----------
Apply patch. rdar://123274678
Commit: 5d81bf2e905b80404c4d59cb14d9eae1bdc1eba3
https://github.com/WebKit/WebKit/commit/5d81bf2e905b80404c4d59cb14d9eae1bdc1eba3
Author: Dan Robson <[email protected]>
Date: 2024-02-20 (Tue, 20 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.14.6
Identifier: [email protected]
Commit: 1a276a144fcd0c802859010e9b21eb73659966de
https://github.com/WebKit/WebKit/commit/1a276a144fcd0c802859010e9b21eb73659966de
Author: Dan Robson <[email protected]>
Date: 2024-02-29 (Thu, 29 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-618.1.15.14.7
Identifier: [email protected]
Compare: https://github.com/WebKit/WebKit/compare/2d60069b2bed%5E...1a276a144fcd
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
