Title: [110519] trunk/Source/WebCore
- Revision
- 110519
- Author
- [email protected]
- Date
- 2012-03-12 18:10:21 -0700 (Mon, 12 Mar 2012)
Log Message
[V8][Refactoring] Make getWrapperSlow() and getExistingWrapperSlow() same
https://bugs.webkit.org/show_bug.cgi?id=80916
Reviewed by Adam Barth.
This is one of the steps for fixing bug 80841.
This patch makes getWrapperSlow() and getExistingWrapperSlow() same.
In the next patch, we will remove getExistingWrapper() and getExistingWrapperSlow().
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getWrapperSlow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (110518 => 110519)
--- trunk/Source/WebCore/ChangeLog 2012-03-13 01:05:54 UTC (rev 110518)
+++ trunk/Source/WebCore/ChangeLog 2012-03-13 01:10:21 UTC (rev 110519)
@@ -1,5 +1,23 @@
2012-03-12 Kentaro Hara <[email protected]>
+ [V8][Refactoring] Make getWrapperSlow() and getExistingWrapperSlow() same
+ https://bugs.webkit.org/show_bug.cgi?id=80916
+
+ Reviewed by Adam Barth.
+
+ This is one of the steps for fixing bug 80841.
+ This patch makes getWrapperSlow() and getExistingWrapperSlow() same.
+ In the next patch, we will remove getExistingWrapper() and getExistingWrapperSlow().
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+ * bindings/v8/V8DOMWrapper.cpp:
+ (WebCore::V8DOMWrapper::getWrapperSlow):
+
+2012-03-12 Kentaro Hara <[email protected]>
+
[V8] Refactor some header includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=80913
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (110518 => 110519)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-03-13 01:05:54 UTC (rev 110518)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-03-13 01:10:21 UTC (rev 110519)
@@ -483,7 +483,10 @@
return v8::Null();
if (UNLIKELY(forceNewObject))
return toV8Slow(impl, forceNewObject);
- return V8DOMWrapper::getWrapper(impl);
+ v8::Handle<v8::Value> wrapper = V8DOMWrapper::getWrapper(impl);
+ if (!wrapper.IsEmpty())
+ return wrapper;
+ return toV8Slow(impl, false);
}
END
}
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp (110518 => 110519)
--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2012-03-13 01:05:54 UTC (rev 110518)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2012-03-13 01:10:21 UTC (rev 110519)
@@ -310,10 +310,7 @@
v8::Handle<v8::Value> V8DOMWrapper::getWrapperSlow(Node* node)
{
- v8::Handle<v8::Object> wrapper = getExistingWrapperInline(node);
- if (!wrapper.IsEmpty())
- return wrapper;
- return toV8Slow(node, false);
+ return getExistingWrapperInline(node);
}
#define TRY_TO_WRAP_WITH_INTERFACE(interfaceName) \
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
