Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7a46d11ffb4d88a4075971be726d8999d8e4230 https://github.com/WebKit/WebKit/commit/e7a46d11ffb4d88a4075971be726d8999d8e4230 Author: Nikolaos Mouchtaris <nmouchta...@apple.com> Date: 2024-03-13 (Wed, 13 Mar 2024)
Changed paths: A LayoutTests/fast/scrolling/mac/scrollbars/rtl-scrollbar-state-expected.txt A LayoutTests/fast/scrolling/mac/scrollbars/rtl-scrollbar-state.html M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h M Source/WebCore/page/scrolling/ScrollingStateNode.h M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.h M Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.h M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h M Source/WebCore/page/scrolling/mac/ScrollerMac.h M Source/WebCore/page/scrolling/mac/ScrollerMac.mm M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm M Source/WebCore/platform/ScrollbarsController.h M Source/WebCore/platform/mac/ScrollbarsControllerMac.mm M Source/WebCore/rendering/RenderBox.cpp M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.mm Log Message: ----------- REGRESSION (Sonoma?): RTL scrollbar incorrect spacing https://bugs.webkit.org/show_bug.cgi?id=263512 rdar://117355120 Reviewed by Simon Fraser. We need to pass changes to shouldPlaceVerticalScrollbarOnLeft to the UI-process so that we can properly set userInterfaceLayoutDirection on the scroller imp. Since on first style change the scrollable area in styleDidChange() doesn't yet have a render layer backing, also pass accross UserInterfaceLayoutDirection when we first set the scrollbar layer as well. * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::setShouldPlaceVerticalScrollbarOnLeft): * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h: * Source/WebCore/page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::setShouldPlaceVerticalScrollbarOnLeft): * Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp: (WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode): * Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingStateNode.h: * Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.cpp: (WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode): * Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.cpp: (WebCore::ScrollingStatePluginScrollingNode::ScrollingStatePluginScrollingNode): * Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::setShouldPlaceVerticalScrollbarOnLeft): * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h: (WebCore::ScrollingStateScrollingNode::shouldPlaceVerticalScrollbarOnLeft const): * Source/WebCore/page/scrolling/mac/ScrollerMac.h: * Source/WebCore/page/scrolling/mac/ScrollerMac.mm: (WebCore::ScrollerMac::setShouldPlaceVerticalScrollbarOnLeft): * Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::updateFromStateNode): * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.mm: (WebKit::RemoteScrollbarsController::RemoteScrollbarsController): (WebKit::RemoteScrollbarsController::mouseMovedInContentArea): Canonical link: https://commits.webkit.org/276040@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes