Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 12aecd5743e3ac7c3a20903dadd971251ca4e6e2
https://github.com/WebKit/WebKit/commit/12aecd5743e3ac7c3a20903dadd971251ca4e6e2
Author: Aditya Keerthi <[email protected]>
Date: 2024-03-14 (Thu, 14 Mar 2024)
Changed paths:
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Log Message:
-----------
[visionOS] Attempting to fullscreen a portrait video on twitter.com displays
the feed
https://bugs.webkit.org/show_bug.cgi?id=270958
rdar://124180748
Reviewed by Abrar Rahman Protyasha.
Fullscreen video on visionOS is intended to be presented at the aspect ratio of
the video element. However, twitter.com tears down its video player if the
fullscreen window has a portrait size, when the original window has a landscape
size. This results in the video disappearing in fullscreen, leaving behind the
feed.
Add a quirk to disable the aspect-ratio based fullscreen window sizing behavior
for twitter.com.
This issue was not caught earlier due to a crash when entering fullscreen on
twitter.com (fixed in 273885@main), and an issue with fullscreen event
ordering (fixed in 275115@main) that resulted in the same bug happening for
*all* videos on twitter.com. Additionally, the issue was temporarily hidden
until a recent regression which accidentally disabled the aspect ratio based
sizing behavior was fixed by 276059@main.
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableFullscreenVideoAspectRatioAdaptiveSizing const):
* Source/WebCore/page/Quirks.h:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):
Canonical link: https://commits.webkit.org/276121@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
