Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b8f448e7fd86b09625e8d8e51ccf96d6d33fe95f
https://github.com/WebKit/WebKit/commit/b8f448e7fd86b09625e8d8e51ccf96d6d33fe95f
Author: Alan Baradlay <[email protected]>
Date: 2024-03-19 (Tue, 19 Mar 2024)
Changed paths:
A LayoutTests/fast/ruby/can-break-before-after-expected.html
A LayoutTests/fast/ruby/can-break-before-after.html
M
LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width.html
M
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
Log Message:
-----------
[IFC][Ruby] Failure to line break before/between ruby sequences
https://bugs.webkit.org/show_bug.cgi?id=271209
<rdar://122663646>
Reviewed by Antti Koivisto.
Not all "do not break before" characters have "do not break after" meaning.
(e.g. no line should begin with KATAKANA MIDDLE DOT but it's ok to have it at
the end of the line).
Let's divide them into 2 categories as seen in https://www.w3.org/TR/jlreq.
*LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width.html:
use different punctuation to force line breaking at the right position.
* LayoutTests/fast/ruby/can-break-before-after-expected.html: Added.
* LayoutTests/fast/ruby/can-break-before-after.html: Added.
*
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::canBreakBefore):
(WebCore::Layout::canBreakAfter):
(WebCore::Layout::RubyFormattingContext::isAtSoftWrapOpportunity):
(WebCore::Layout::canBreakAtCharacter): Deleted.
Canonical link: https://commits.webkit.org/276353@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
