Title: [110567] trunk/Source/WebCore
- Revision
- 110567
- Author
- [email protected]
- Date
- 2012-03-13 08:28:56 -0700 (Tue, 13 Mar 2012)
Log Message
New PageCache histogram which counts failures ignoring Settings.
https://bugs.webkit.org/show_bug.cgi?id=80864
Reviewed by Brady Eidson.
Chrome has a command line switch to turn on the page cache.
Currently it doesn't work, but it can cause the PageCache reasons
for failure count to read lower than it should. Add a new
histogram to report the corrected value.
* history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (110566 => 110567)
--- trunk/Source/WebCore/ChangeLog 2012-03-13 15:24:02 UTC (rev 110566)
+++ trunk/Source/WebCore/ChangeLog 2012-03-13 15:28:56 UTC (rev 110567)
@@ -1,3 +1,18 @@
+2012-03-13 Gavin Peters <[email protected]>
+
+ New PageCache histogram which counts failures ignoring Settings.
+ https://bugs.webkit.org/show_bug.cgi?id=80864
+
+ Reviewed by Brady Eidson.
+
+ Chrome has a command line switch to turn on the page cache.
+ Currently it doesn't work, but it can cause the PageCache reasons
+ for failure count to read lower than it should. Add a new
+ histogram to report the corrected value.
+
+ * history/PageCache.cpp:
+ (WebCore::logCanCachePageDecision):
+
2012-03-13 George Staikos <[email protected]>
Fix signed/unsigned mismatch compiler warnings.
Modified: trunk/Source/WebCore/history/PageCache.cpp (110566 => 110567)
--- trunk/Source/WebCore/history/PageCache.cpp 2012-03-13 15:24:02 UTC (rev 110566)
+++ trunk/Source/WebCore/history/PageCache.cpp 2012-03-13 15:28:56 UTC (rev 110567)
@@ -264,6 +264,8 @@
}
}
HistogramSupport::histogramEnumeration("PageCache.PageRejectReasonCount", reasonCount, 1 + NumberOfReasonsPagesCannotBeInPageCache);
+ const bool settingsDisabledPageCache = rejectReasons & (1 << DisabledPageCache);
+ HistogramSupport::histogramEnumeration("PageCache.PageRejectReasonCountExcludingSettings", reasonCount - settingsDisabledPageCache, NumberOfReasonsPagesCannotBeInPageCache);
// Report also on the frame reasons by page; this is distinct from the per frame statistics since it coalesces the
// causes from all subframes together.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
