Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 531dc1cbbb66a57f3f8a0dfd97add5f2e1ed4a5c
https://github.com/WebKit/WebKit/commit/531dc1cbbb66a57f3f8a0dfd97add5f2e1ed4a5c
Author: Antoine Quint <[email protected]>
Date: 2024-03-21 (Thu, 21 Mar 2024)
Changed paths:
M
LayoutTests/imported/blink/fast/css-generated-content/pseudo-animation-display-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-interpolation-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-dont-cancel.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-display/animations/display-interpolation-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-display/animations/display-interpolation.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
Log Message:
-----------
[web-animations] make the `display` property animatable
https://bugs.webkit.org/show_bug.cgi?id=271372
Reviewed by Tim Nguyen.
As part of the work to add interpolation support for the `display` property
(see bug 267762) we need
to make that property animatable. We add basic support with a new wrapper in
CSSPropertyAnimation.cpp,
but more work will be needed to deal with the more tricky aspects of `display:
none` values encountered
before and after applying animations during style resolution.
It is expected that the WPT test
`css/css-display/animations/display-interpolation.html` now has FAIL
results since this test is not aware of `display` being an animatable property.
That test is superseded
by `css/css-display/animations/display-interpolation.tentative.html` but both
tests currently co-exist
in the WPT suite so we retain both of them.
Likewise, we alter the WPT test
`web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html`
to no longer assume the `display` property is not animatable.
Finally, the test
`imported/blink/fast/css-generated-content/pseudo-animation-display.html` now
fails.
That test also fails in Chrome [0] after they've added animation support for
the `display` property, but our
failures aren't the same. I've filed an issue with the CSS WG [1] to discuss
this and ensure we get WPT coverage.
[0]
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestExpectations;l=3487;bpv=1;bpt=1
[1] https://github.com/w3c/csswg-drafts/issues/10111
*
LayoutTests/imported/blink/fast/css-generated-content/pseudo-animation-display-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-interpolation-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-dont-cancel.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-display/animations/display-interpolation-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-display/animations/display-interpolation.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
Canonical link: https://commits.webkit.org/276464@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
