Modified: trunk/Source/WebCore/ChangeLog (110583 => 110584)
--- trunk/Source/WebCore/ChangeLog 2012-03-13 18:17:00 UTC (rev 110583)
+++ trunk/Source/WebCore/ChangeLog 2012-03-13 18:21:14 UTC (rev 110584)
@@ -1,3 +1,15 @@
+2012-03-13 Pavel Feldman <[email protected]>
+
+ Web Inspector: front-end compilation was broken while supporting large arrays.
+ https://bugs.webkit.org/show_bug.cgi?id=81013
+
+ Reviewed by Vsevolod Vlasov.
+
+ * inspector/front-end/ExtensionPanel.js:
+ * inspector/front-end/ObjectPropertiesSection.js:
+ (WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.buildObjectFragment):
+ * inspector/front-end/RemoteObject.js:
+
2012-03-13 Tony Chang <[email protected]>
flexbox's computePreferredLogicalWidth needs to take multiline into account
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js (110583 => 110584)
--- trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2012-03-13 18:17:00 UTC (rev 110583)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2012-03-13 18:21:14 UTC (rev 110584)
@@ -302,7 +302,7 @@
},
/**
- * @param {Object} object
+ * @param {WebInspector.RemoteObject} object
* @param {string} title
* @param {function(?string=)} callback
*/
Modified: trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js (110583 => 110584)
--- trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2012-03-13 18:17:00 UTC (rev 110583)
+++ trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2012-03-13 18:21:14 UTC (rev 110584)
@@ -27,7 +27,7 @@
/**
* @constructor
* @extends {WebInspector.PropertiesSection}
- * @param {*=} object
+ * @param {WebInspector.RemoteObject=} object
* @param {string=} title
* @param {string=} subtitle
* @param {string=} emptyPlaceholder
@@ -465,6 +465,7 @@
{
object.callFunctionJSON(packRanges, [{value: fromIndex}, {value: toIndex}, {value: WebInspector.ArrayGroupingTreeElement._bucketThreshold}], callback.bind(this));
+ /** @this {Object} */
function packRanges(fromIndex, toIndex, bucketThreshold)
{
var count = 0;
@@ -538,6 +539,7 @@
{
object.callFunction(buildArrayFragment, [{value: fromIndex}, {value: toIndex}], processArrayFragment.bind(this));
+ /** @this {Object} */
function buildArrayFragment(fromIndex, toIndex)
{
var result = Object.create(null);
@@ -554,6 +556,7 @@
arrayFragment.getAllProperties(processProperties.bind(this));
}
+ /** @this {WebInspector.ArrayGroupingTreeElement} */
function processProperties(properties)
{
if (!properties)
@@ -577,6 +580,7 @@
{
object.callFunction(buildObjectFragment, undefined, processObjectFragment.bind(this));
+ /** @this {Object} */
function buildObjectFragment()
{
var result = Object.create(this.__proto__);
@@ -586,7 +590,8 @@
if (!isNaN(name))
continue;
var descriptor = Object.getOwnPropertyDescriptor(this, name);
- Object.defineProperty(result, name, descriptor);
+ if (descriptor)
+ Object.defineProperty(result, name, descriptor);
}
return result;
}
@@ -596,6 +601,7 @@
arrayFragment.getOwnProperties(processProperties.bind(this));
}
+ /** @this {WebInspector.ArrayGroupingTreeElement} */
function processProperties(properties)
{
if (!properties)
Modified: trunk/Source/WebCore/inspector/front-end/RemoteObject.js (110583 => 110584)
--- trunk/Source/WebCore/inspector/front-end/RemoteObject.js 2012-03-13 18:17:00 UTC (rev 110583)
+++ trunk/Source/WebCore/inspector/front-end/RemoteObject.js 2012-03-13 18:21:14 UTC (rev 110584)
@@ -271,8 +271,8 @@
},
/**
- * @param {string} functionDeclaration
- * @param {Array.<RuntimeAgent.CallArgument>} args
+ * @param {function(*)} functionDeclaration
+ * @param {Array.<RuntimeAgent.CallArgument>|undefined} args
* @param {function(?WebInspector.RemoteObject)} callback
*/
callFunction: function(functionDeclaration, args, callback)
@@ -286,8 +286,8 @@
},
/**
- * @param {string} functionDeclaration
- * @param {Array.<RuntimeAgent.CallArgument>} args
+ * @param {function(*)} functionDeclaration
+ * @param {Array.<RuntimeAgent.CallArgument>|undefined} args
* @param {function(*)} callback
*/
callFunctionJSON: function(functionDeclaration, args, callback)
