Title: [110600] trunk/Source/WebKit/chromium
- Revision
- 110600
- Author
- [email protected]
- Date
- 2012-03-13 13:47:58 -0700 (Tue, 13 Mar 2012)
Log Message
Implement ApplicationCacheHost::canCacheInPageCache() for chromium.
https://bugs.webkit.org/show_bug.cgi?id=80905
Reviewed by Eric Seidel.
This won't cause chrome to use the PageCache, but it will cause our histogram statistics
describing PageCache use to be more accurate.
* src/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::canCacheInPageCache):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (110599 => 110600)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-13 20:30:24 UTC (rev 110599)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-13 20:47:58 UTC (rev 110600)
@@ -1,3 +1,16 @@
+2012-03-13 Gavin Peters <[email protected]>
+
+ Implement ApplicationCacheHost::canCacheInPageCache() for chromium.
+ https://bugs.webkit.org/show_bug.cgi?id=80905
+
+ Reviewed by Eric Seidel.
+
+ This won't cause chrome to use the PageCache, but it will cause our histogram statistics
+ describing PageCache use to be more accurate.
+
+ * src/ApplicationCacheHost.cpp:
+ (WebCore::ApplicationCacheHost::canCacheInPageCache):
+
2012-03-13 Dana Jansens <[email protected]>
[chromium] Use CCOcclusionTracker for draw culling
Modified: trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp (110599 => 110600)
--- trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp 2012-03-13 20:30:24 UTC (rev 110599)
+++ trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp 2012-03-13 20:47:58 UTC (rev 110600)
@@ -195,8 +195,10 @@
bool ApplicationCacheHost::canCacheInPageCache()
{
- // N/A to the chromium port which doesn't use the page cache.
- return false;
+ // Chromium doesn't use the page cache, however, that's controlled by WebCore::Settings, which has usesPageCache() return
+ // false. So we return an hyptothetical here: Chromium won't end up using the PageCache, but the statistics in PageCache.cpp
+ // will be reported correctly for re-evaluating that decision.
+ return !isApplicationCacheEnabled() || status() == UNCACHED;
}
void ApplicationCacheHost::setDOMApplicationCache(DOMApplicationCache* domApplicationCache)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
