Title: [110618] trunk/Source/WebCore
- Revision
- 110618
- Author
- [email protected]
- Date
- 2012-03-13 14:59:06 -0700 (Tue, 13 Mar 2012)
Log Message
Remove vestigal abortEvent from image attribute.
https://bugs.webkit.org/show_bug.cgi?id=80795
Reviewed by Adam Barth.
It seems we installed a listener for the abort event on images,
but never ever raised them. So this patch removes it. This could
cause different behaviour if the user sends abort events directly
at an image element, although addEventListener will still work.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (110617 => 110618)
--- trunk/Source/WebCore/ChangeLog 2012-03-13 21:52:27 UTC (rev 110617)
+++ trunk/Source/WebCore/ChangeLog 2012-03-13 21:59:06 UTC (rev 110618)
@@ -1,3 +1,18 @@
+2012-03-13 Gavin Peters <[email protected]>
+
+ Remove vestigal abortEvent from image attribute.
+ https://bugs.webkit.org/show_bug.cgi?id=80795
+
+ Reviewed by Adam Barth.
+
+ It seems we installed a listener for the abort event on images,
+ but never ever raised them. So this patch removes it. This could
+ cause different behaviour if the user sends abort events directly
+ at an image element, although addEventListener will still work.
+
+ * html/HTMLImageElement.cpp:
+ (WebCore::HTMLImageElement::parseAttribute):
+
2012-03-13 Nate Chapin <[email protected]>
Rework how a CachedRawResource decides if it can be reused
Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (110617 => 110618)
--- trunk/Source/WebCore/html/HTMLImageElement.cpp 2012-03-13 21:52:27 UTC (rev 110617)
+++ trunk/Source/WebCore/html/HTMLImageElement.cpp 2012-03-13 21:59:06 UTC (rev 110618)
@@ -117,8 +117,6 @@
m_imageLoader.updateFromElementIgnoringPreviousError();
else if (attrName == usemapAttr)
setIsLink(!attr->isNull());
- else if (attrName == onabortAttr)
- setAttributeEventListener(eventNames().abortEvent, createAttributeEventListener(this, attr));
else if (attrName == onloadAttr)
setAttributeEventListener(eventNames().loadEvent, createAttributeEventListener(this, attr));
else if (attrName == onbeforeloadAttr)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
