Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dfe516cf9002fa5b9936644df7af3ff9f8e7c217
https://github.com/WebKit/WebKit/commit/dfe516cf9002fa5b9936644df7af3ff9f8e7c217
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2024-03-29 (Fri, 29 Mar 2024)
Changed paths:
M LayoutTests/fast/viewport/ios/viewport-fit-auto-expected.txt
M LayoutTests/fast/viewport/ios/viewport-fit-auto.html
M LayoutTests/fast/viewport/ios/viewport-fit-contain-expected.txt
M LayoutTests/fast/viewport/ios/viewport-fit-contain.html
M LayoutTests/fast/viewport/ios/viewport-fit-cover-expected.txt
M LayoutTests/fast/viewport/ios/viewport-fit-cover.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm
M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h
M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm
Log Message:
-----------
[iOS] 3 fast/viewport/ios/viewport-fit-*.html layout tests constantly failing.
https://bugs.webkit.org/show_bug.cgi?id=271778
rdar://125502337
Reviewed by Wenson Hsieh.
This patch addresses the failing fast/viewport/ios/viewport-fit-*.html
layout tests in two distinct ways:
1. The test expectations around the screen dimensions were updated to
reflect the fact that layout tests now run in an iPhone 12 simulator,
and not an iPhone SE simulator, which the stale expectations
correspond to.
2. The tests sometimes flakily fail because some overriden safe area
inset values are not reflected in the screen dimensions queried
post visible rect update. This is fixed by delegating that same test
query to after a visible rect update and the next stable presentation
update, which required hooking up some new functionality in WKWebView
testing API, as well as UIScriptController.
* LayoutTests/fast/viewport/ios/viewport-fit-auto-expected.txt:
* LayoutTests/fast/viewport/ios/viewport-fit-auto.html:
* LayoutTests/fast/viewport/ios/viewport-fit-contain-expected.txt:
* LayoutTests/fast/viewport/ios/viewport-fit-contain.html:
* LayoutTests/fast/viewport/ios/viewport-fit-cover-expected.txt:
* LayoutTests/fast/viewport/ios/viewport-fit-cover.html:
* LayoutTests/platform/ios/TestExpectations:
Remove the failing annotations for the tests we're addressing.
* Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm:
(-[WKWebView _doAfterNextVisibleContentRectAndStablePresentationUpdate:]):
* Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::doAfterNextVisibleContentRectAndStablePresentationUpdate):
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h:
* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::doAfterNextVisibleContentRectAndStablePresentationUpdate):
(WTR::UIScriptControllerIOS::zoomToScale):
(WTR::setModifierFlagsForUIPhysicalKeyboardEvent): Deleted.
Canonical link: https://commits.webkit.org/276847@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
