Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 479a96130343233469e70e06d1d4c03d93ab05ce
https://github.com/WebKit/WebKit/commit/479a96130343233469e70e06d1d4c03d93ab05ce
Author: Ryosuke Niwa <[email protected]>
Date: 2024-04-02 (Tue, 02 Apr 2024)
Changed paths:
M LayoutTests/fast/forms/ios/focus-textarea.html
M
LayoutTests/platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/editing/FrameSelection.h
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
Log Message:
-----------
Release assert in canExecuteScripts via Editor::setComposition through
FrameSelection::willBeRemovedFromFrame
https://bugs.webkit.org/show_bug.cgi?id=271858
Reviewed by Wenson Hsieh.
Don't notify EditorClient in setSelectionWithoutUpdatingAppearance when we're
in the midst of detaching from Frame.
* LayoutTests/fast/forms/ios/focus-textarea.html: Fix the flakiness in this
test by explicitly focusing the textarea.
* LayoutTests/platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt:
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::willBeRemovedFromFrame):
* Source/WebCore/editing/FrameSelection.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::transitionToCommittedForNewPage): Schedule
editor state to be updated.
Without this change,
TestWebKitAPI.EditorStateTests.ObserveSelectionAttributeChanges will fail.
Canonical link: https://commits.webkit.org/276962@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
