Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb425171fec8fd7ecc3a326e6f62aafcbc674974
      
https://github.com/WebKit/WebKit/commit/fb425171fec8fd7ecc3a326e6f62aafcbc674974
  Author: Qianlang Chen <[email protected]>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js

  Log Message:
  -----------
  Web Inspector: Console and code editor completion does not auto-scroll 
suggestion into view
rdar://124979790
https://bugs.webkit.org/show_bug.cgi?id=271205

Reviewed by Devin Rousso.

In the original code, there is logic to scroll a newly-selected item
into view in the `CompletionSuggestionsView.selectedIndex` setter, but
when the list of suggestions is updated with the `update` method, there
is no similar logic to scroll the default selection into view.

* Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:
(WI.CompletionSuggestionsView.prototype.update):
   - Make sure to let the to-be-selected element scrollIntoViewIfNeeded.

Canonical link: https://commits.webkit.org/277034@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to