Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5eb211273e066dc9a0b4a11cb3598efc659ba50e
https://github.com/WebKit/WebKit/commit/5eb211273e066dc9a0b4a11cb3598efc659ba50e
Author: Ryosuke Niwa <[email protected]>
Date: 2024-04-04 (Thu, 04 Apr 2024)
Changed paths:
M LayoutTests/fast/forms/form-validation.js
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/html/ValidatedFormListedElement.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
Log Message:
-----------
REGRESSION ( Sonoma ): [ Sonoma w2 ]
fast/forms/scroll-into-view-and-show-validation-message.html is a consistent
failure.
https://bugs.webkit.org/show_bug.cgi?id=263049
Reviewed by Simon Fraser and Wenson Hsieh.
The flakiness was caused by the race condition between callOnMainThread and
rendering update. Namely, we sometimes fail
to scroll to reveal before showing the validation bubble. Fixed the bug by
aligning the validation bubble appearance to
happen after rendering update in Page::doAfterUpdateRendering.
* LayoutTests/fast/forms/form-validation.js:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/html/ValidatedFormListedElement.cpp:
(WebCore::ValidatedFormListedElement::focusAndShowValidationMessage):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::scheduleValidationMessageUpdate): Added.
(WebCore::Page::updateValidationMessages): Added.
(WebCore::Page::doAfterUpdateRendering):
* Source/WebCore/page/Page.h:
Canonical link: https://commits.webkit.org/277069@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
