Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 16e1300785215bc82cc0b0f52bc35690589e3e2e
https://github.com/WebKit/WebKit/commit/16e1300785215bc82cc0b0f52bc35690589e3e2e
Author: Alan Baradlay <[email protected]>
Date: 2024-04-05 (Fri, 05 Apr 2024)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
Log Message:
-----------
[RenderTreeBuilder][Cleanup] detachFromRenderElement keeps checking
renderTreeBeingDestroyed
https://bugs.webkit.org/show_bug.cgi?id=272229
Reviewed by Antti Koivisto.
1. Early return on renderTreeBeingDestroyed
- detachRendererInternal is the only function we need to call
2. Most of the reset/invalidate functions only ever apply when everHadLayout is
true
- group them under a new static function "resetRendererState"
{
if (parent.renderTreeBeingDestroyed())
return parent.detachRendererInternal(child);
if (child.everHadLayout())
resetRendererState();
rest of must-cleanup functions
}
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::resetRendererState):
(WebCore::RenderTreeBuilder::detachFromRenderElement):
Canonical link: https://commits.webkit.org/277144@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
