Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 15c31e21d87705f509b1206beee9eee170e6cda3
https://github.com/WebKit/WebKit/commit/15c31e21d87705f509b1206beee9eee170e6cda3
Author: Tadeu Zagallo <tzaga...@apple.com>
Date: 2024-04-08 (Mon, 08 Apr 2024)
Changed paths:
A
LayoutTests/http/tests/webgpu/webgpu/shader/validation/shader_io/workgroup_size-expected.txt
M Source/WebGPU/WGSL/TypeCheck.cpp
Log Message:
-----------
[WebGPU]
https://gpuweb.github.io/cts/standalone/?q=webgpu:api,operation,compute_pipeline,overrides:workgroup_size:isAsync=true;type=%22u32%22;size=3;v=%22y%22
is failing
https://bugs.webkit.org/show_bug.cgi?id=272204
rdar://125945949
Reviewed by Mike Wyrzykowski and Dan Glastonbury.
In 275374@main I changed some of the attribute type checking to use a new
`check` helper,
which checks if a type satisfies a constraint and then concretizes it if
necessary. That
helper was being used when checking the `@workgroup_size`, which is not
correct, since we
cannot concretize the type of each argument individually.
*
LayoutTests/http/tests/webgpu/webgpu/shader/validation/shader_io/workgroup_size-expected.txt:
Added.
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
Canonical link: https://commits.webkit.org/277193@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
