Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1a7bea21fb470e352743786b98cac1b5b5e6ca5a
https://github.com/WebKit/WebKit/commit/1a7bea21fb470e352743786b98cac1b5b5e6ca5a
Author: Per Arne Vollan <[email protected]>
Date: 2024-04-08 (Mon, 08 Apr 2024)
Changed paths:
M Source/WebKit/GPUProcess/mac/GPUProcessMac.mm
M Source/WebKit/Shared/AuxiliaryProcess.h
M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Log Message:
-----------
Avoid IPC to OpenDirectory XPC service on main thread
https://bugs.webkit.org/show_bug.cgi?id=272192
rdar://123778399
Reviewed by Sihui Liu.
Avoid IPC to OpenDirectory XPC service on main thread, since it can potentially
block the main thread for a long time.
This IPC is called in response to a notification from the UI process when the
Open Directory cache has been invalidated.
There is a window of time where calling getpwuid_r and related functions in the
WebContent process can return stale
values after the cache has been invalidated. This is still an issue after this
patch and should be addressed, but it
may be outside the scope of this patch. WebKit is only calling this function
before entering the sandbox, where we will
never get stale values. It is however possible that other frameworks are
calling this function, but I am not aware of
that being the case, currently.
* Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:
(WebKit::GPUProcess::openDirectoryCacheInvalidated):
* Source/WebKit/Shared/AuxiliaryProcess.h:
* Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::openDirectoryCacheInvalidated):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::openDirectoryCacheInvalidated):
Canonical link: https://commits.webkit.org/277204@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
