[webkit-changes] [110664] trunk

Tue, 13 Mar 2012 23:35:59 -0700

Title: [110664] trunk
Revision
110664
Author
[email protected]
Date
2012-03-13 23:35:49 -0700 (Tue, 13 Mar 2012)

Log Message

[Forms] The "output" element should have labels.
https://bugs.webkit.org/show_bug.cgi?id=80466

Patch by Yosifumi Inoue <[email protected]> on 2012-03-13
Reviewed by Kent Tamura.

Source/WebCore:

This patch enables functionality of "labels" attribute for
HTMLOutputElement implemented in LabelableElement which use
isLabelable predicate whether an element can have label or not.

Update existing tests in fast/forms/label/ directory to cover
the "output" element with the "labels" attribute.

* html/HTMLOutputElement.h: Implement virtual method isLabelable.

LayoutTests:

This patch updates expectation for functioning the "labels"
attribute of the "output" elements which was not working
so far.

* fast/forms/label/labelable-elements-expected.txt:
* fast/forms/label/labels-add-htmlFor-label-expected.txt:
* fast/forms/label/labels-add-parent-label-expected.txt:
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-multiple-sibling-labels-expected.txt:
* fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-remove-htmlFor-label-expected.txt:
* fast/forms/label/labels-remove-parent-label-expected.txt:
* fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
* platform/chromium/fast/forms/label/labelable-elements-expected.txt:
* platform/mac/fast/forms/label/labelable-elements-expected.txt

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (110663 => 110664)


--- trunk/LayoutTests/ChangeLog	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/ChangeLog	2012-03-14 06:35:49 UTC (rev 110664)
@@ -1,3 +1,27 @@
+2012-03-13  Yosifumi Inoue  <[email protected]>
+
+        [Forms] The "output" element should have labels.
+        https://bugs.webkit.org/show_bug.cgi?id=80466
+
+        Reviewed by Kent Tamura.
+
+        This patch updates expectation for functioning the "labels"
+        attribute of the "output" elements which was not working
+        so far.
+
+        * fast/forms/label/labelable-elements-expected.txt:
+        * fast/forms/label/labels-add-htmlFor-label-expected.txt:
+        * fast/forms/label/labels-add-parent-label-expected.txt:
+        * fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
+        * fast/forms/label/labels-multiple-sibling-labels-expected.txt:
+        * fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
+        * fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
+        * fast/forms/label/labels-remove-htmlFor-label-expected.txt:
+        * fast/forms/label/labels-remove-parent-label-expected.txt:
+        * fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
+        * platform/chromium/fast/forms/label/labelable-elements-expected.txt:
+        * platform/mac/fast/forms/label/labelable-elements-expected.txt
+
 2012-03-13  Hajime Morrita  <[email protected]>
 
         Unreviewed, marking some tests flaky.

Modified: trunk/LayoutTests/fast/forms/label/labelable-elements-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labelable-elements-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labelable-elements-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -45,7 +45,7 @@
 PASS element.labels is not null
 
 Labelable: output [object HTMLOutputElement]
-FAIL element.labels.length should be 1. Threw exception TypeError: Cannot read property 'length' of null
+PASS element.labels.length is 1
 
 Labelable: progress [object HTMLProgressElement]
 PASS element.labels.length is 1

Modified: trunk/LayoutTests/fast/forms/label/labels-add-htmlFor-label-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labels-add-htmlFor-label-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labels-add-htmlFor-label-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -15,6 +15,9 @@
 Check meter
 PASS element.labels.length is 0
 PASS element.labels.length is 1
+Check output
+PASS element.labels.length is 0
+PASS element.labels.length is 1
 Check progress
 PASS element.labels.length is 0
 PASS element.labels.length is 1

Modified: trunk/LayoutTests/fast/forms/label/labels-add-parent-label-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labels-add-parent-label-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labels-add-parent-label-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -15,6 +15,9 @@
 Check meter
 PASS element.labels.length is 0
 PASS element.labels.length is 1
+Check output
+PASS element.labels.length is 0
+PASS element.labels.length is 1
 Check progress
 PASS element.labels.length is 0
 PASS element.labels.length is 1

Modified: trunk/LayoutTests/fast/forms/label/labels-change-htmlFor-attribute-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labels-change-htmlFor-attribute-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labels-change-htmlFor-attribute-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -15,6 +15,9 @@
 Check meter
 PASS element.labels.length is 0
 PASS element.labels.length is 1
+Check output
+PASS element.labels.length is 0
+PASS element.labels.length is 1
 Check progress
 PASS element.labels.length is 0
 PASS element.labels.length is 1

Modified: trunk/LayoutTests/fast/forms/label/labels-multiple-sibling-labels-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labels-multiple-sibling-labels-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labels-multiple-sibling-labels-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -11,6 +11,8 @@
 PASS element.labels.length is 2
 Check meter
 PASS element.labels.length is 2
+Check output
+PASS element.labels.length is 2
 Check progress
 PASS element.labels.length is 2
 Check select

Modified: trunk/LayoutTests/fast/forms/label/labels-parent-and-sibling-labels-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labels-parent-and-sibling-labels-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labels-parent-and-sibling-labels-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -11,6 +11,8 @@
 PASS element.labels.length is 2
 Check meter
 PASS element.labels.length is 2
+Check output
+PASS element.labels.length is 2
 Check progress
 PASS element.labels.length is 2
 Check select

Modified: trunk/LayoutTests/fast/forms/label/labels-remove-htmlFor-attribute-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labels-remove-htmlFor-attribute-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labels-remove-htmlFor-attribute-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -15,6 +15,9 @@
 Check meter
 PASS element.labels.length is 1
 PASS element.labels.length is 0
+Check output
+PASS element.labels.length is 1
+PASS element.labels.length is 0
 Check progress
 PASS element.labels.length is 1
 PASS element.labels.length is 0

Modified: trunk/LayoutTests/fast/forms/label/labels-remove-htmlFor-label-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labels-remove-htmlFor-label-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labels-remove-htmlFor-label-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -15,6 +15,9 @@
 Check meter
 PASS element.labels.length is 1
 PASS element.labels.length is 0
+Check output
+PASS element.labels.length is 1
+PASS element.labels.length is 0
 Check progress
 PASS element.labels.length is 1
 PASS element.labels.length is 0

Modified: trunk/LayoutTests/fast/forms/label/labels-remove-parent-label-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labels-remove-parent-label-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labels-remove-parent-label-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -15,6 +15,9 @@
 Check meter
 PASS element.labels.length is 1
 PASS element.labels.length is 0
+Check output
+PASS element.labels.length is 1
+PASS element.labels.length is 0
 Check progress
 PASS element.labels.length is 1
 PASS element.labels.length is 0

Modified: trunk/LayoutTests/fast/forms/label/labels-set-htmlFor-attribute-expected.txt (110663 => 110664)


--- trunk/LayoutTests/fast/forms/label/labels-set-htmlFor-attribute-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/fast/forms/label/labels-set-htmlFor-attribute-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -15,6 +15,9 @@
 Check meter
 PASS element.labels.length is 0
 PASS element.labels.length is 1
+Check output
+PASS element.labels.length is 0
+PASS element.labels.length is 1
 Check progress
 PASS element.labels.length is 0
 PASS element.labels.length is 1

Modified: trunk/LayoutTests/platform/chromium/fast/forms/label/labelable-elements-expected.txt (110663 => 110664)


--- trunk/LayoutTests/platform/chromium/fast/forms/label/labelable-elements-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/platform/chromium/fast/forms/label/labelable-elements-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -45,7 +45,7 @@
 PASS element.labels is not null
 
 Labelable: output [object HTMLOutputElement]
-FAIL element.labels.length should be 1. Threw exception TypeError: Cannot read property 'length' of null
+PASS element.labels.length is 1
 
 Labelable: progress [object HTMLProgressElement]
 PASS element.labels.length is 1

Modified: trunk/LayoutTests/platform/mac/fast/forms/label/labelable-elements-expected.txt (110663 => 110664)


--- trunk/LayoutTests/platform/mac/fast/forms/label/labelable-elements-expected.txt	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/LayoutTests/platform/mac/fast/forms/label/labelable-elements-expected.txt	2012-03-14 06:35:49 UTC (rev 110664)
@@ -45,7 +45,7 @@
 PASS element.labels is not null
 
 Labelable: output [object HTMLOutputElement]
-FAIL element.labels.length should be 1. Threw exception TypeError: 'null' is not an object (evaluating 'element.labels.length')
+PASS element.labels.length is 1
 
 Labelable: progress [object HTMLProgressElement]
 PASS element.labels.length is 1

Modified: trunk/Source/WebCore/ChangeLog (110663 => 110664)


--- trunk/Source/WebCore/ChangeLog	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/Source/WebCore/ChangeLog	2012-03-14 06:35:49 UTC (rev 110664)
@@ -1,3 +1,19 @@
+2012-03-13  Yosifumi Inoue  <[email protected]>
+
+        [Forms] The "output" element should have labels.
+        https://bugs.webkit.org/show_bug.cgi?id=80466
+
+        Reviewed by Kent Tamura.
+
+        This patch enables functionality of "labels" attribute for
+        HTMLOutputElement implemented in LabelableElement which use
+        isLabelable predicate whether an element can have label or not.
+
+        Update existing tests in fast/forms/label/ directory to cover
+        the "output" element with the "labels" attribute.
+
+        * html/HTMLOutputElement.h: Implement virtual method isLabelable.
+
 2012-03-13  Luke Macpherson   <[email protected]>
 
         Move opacity clamping into RenderStyle setter.

Modified: trunk/Source/WebCore/html/HTMLOutputElement.h (110663 => 110664)


--- trunk/Source/WebCore/html/HTMLOutputElement.h	2012-03-14 06:24:15 UTC (rev 110663)
+++ trunk/Source/WebCore/html/HTMLOutputElement.h	2012-03-14 06:35:49 UTC (rev 110664)
@@ -58,6 +58,7 @@
     virtual void parseAttribute(Attribute*) OVERRIDE;
     virtual const AtomicString& formControlType() const;
     virtual bool isEnumeratable() const { return true; }
+    virtual bool isLabelable() const OVERRIDE { return true; }
     virtual bool supportsFocus() const;
     virtual void childrenChanged(bool createdByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0);
     virtual void reset();

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to