Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6beb22fd66bd2e19de4b8668f26df5597f6c49c3
https://github.com/WebKit/WebKit/commit/6beb22fd66bd2e19de4b8668f26df5597f6c49c3
Author: Alex Christensen <achristen...@apple.com>
Date: 2024-04-09 (Tue, 09 Apr 2024)
Changed paths:
M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
Log Message:
-----------
Remove incorrect assertion in BrowsingContextGroup::removePage
https://bugs.webkit.org/show_bug.cgi?id=272377
rdar://126116452
Reviewed by Charlie Wolfe.
We currently don't call BrowsingContextGroup::addPage until the UI process
receives a message that the main frame has been created. If window.close is
called before then, many API clients will deallocate an opened page immediately.
Add a test for this case and remove the invalid assertion.
* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::removePage):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::openerAndOpenedViews):
(TestWebKitAPI::TEST(SiteIsolation, OpenThenClose)):
Canonical link: https://commits.webkit.org/277242@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
