Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e123f4c6215c28a36784bd937c37c1be9889205d
https://github.com/WebKit/WebKit/commit/e123f4c6215c28a36784bd937c37c1be9889205d
Author: Mike Wyrzykowski <[email protected]>
Date: 2024-04-10 (Wed, 10 Apr 2024)
Changed paths:
M Source/WebGPU/WebGPU/BindGroupLayout.h
M Source/WebGPU/WebGPU/BindGroupLayout.mm
M Source/WebGPU/WebGPU/ComputePassEncoder.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
Log Message:
-----------
[WebGPU] bool BindGroupLayout::validateDynamicOffsets should return a better
error message
https://bugs.webkit.org/show_bug.cgi?id=272378
rdar://126119539
Reviewed by Tadeu Zagallo.
PlayCanvas recently encountered an error that would have been easily diagnosable
had we surfaced better error messages from validateDynamicOffsets, so update
that
function to do so.
PlayCanvas issue is reported in https://bugs.webkit.org/show_bug.cgi?id=270079
* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::BindGroupLayout::errorValidatingDynamicOffsets const):
(WebGPU::BindGroupLayout::validateDynamicOffsets const): Deleted.
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::setBindGroup):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::setBindGroup):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::setBindGroup):
Canonical link: https://commits.webkit.org/277318@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
