Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 040cadd0e752cb1b5b307278fbd635097c729efd
https://github.com/WebKit/WebKit/commit/040cadd0e752cb1b5b307278fbd635097c729efd
Author: Antti Koivisto <[email protected]>
Date: 2024-04-15 (Mon, 15 Apr 2024)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed.html
M Source/WebCore/css/BasicShapeFunctions.cpp
M Source/WebCore/platform/Length.cpp
M Source/WebCore/platform/Length.h
Log Message:
-----------
REGRESSION(272180@main): Crash in CSSCalcOperationNode::simplifyRecursive
with xywh() and rect() clip-paths
https://bugs.webkit.org/show_bug.cgi?id=270296
rdar://123508905
Reviewed by Darin Adler.
Clip path serialization produces inset() values which requires constructing
calc expressions if the original
values are not insets. The code for this didn't work correctly if the values
were calc expressions thenselves.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt:
The results are correct though FAILs because they are not maximally simplified.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed.html:
Update from the WPT repo.
* Source/WebCore/css/BasicShapeFunctions.cpp:
Use the existing convertTo100PercentMinusLength instead of trying to do this
manually.
(WebCore::valueForBasicShape):
* Source/WebCore/platform/Length.cpp:
(WebCore::convertTo100PercentMinusLengthSum):
Add a separate dual-argument version. This is needed so we can do some manual
simplification (see the comment).
* Source/WebCore/platform/Length.h:
Canonical link: https://commits.webkit.org/277500@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
