Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d6540a38e780083381887f821396c17f3b8391f0
https://github.com/WebKit/WebKit/commit/d6540a38e780083381887f821396c17f3b8391f0
Author: Chris Dumez <[email protected]>
Date: 2024-04-15 (Mon, 15 Apr 2024)
Changed paths:
M Source/WebKit/Shared/AuxiliaryProcess.h
M Source/WebKit/Shared/AuxiliaryProcess.messages.in
M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
M Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm
Log Message:
-----------
Regression(277427@main) Crash under
AuxiliaryProcessProxy::notifyPreferencesChanged()
https://bugs.webkit.org/show_bug.cgi?id=272695
rdar://126492909
Reviewed by Per Arne Vollan.
We were using a HashMap to store preferences whose key was a std::pair<String,
String>.
The first String was the domain and the second the preference name. However,
for global
preferences, the domain is null, causing a crash when hashing the key.
To address an issue, we now store global preferences in a separate HashMap.
* Source/WebKit/Shared/AuxiliaryProcess.h:
* Source/WebKit/Shared/AuxiliaryProcess.messages.in:
* Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::preferencesDidUpdate):
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::didChangeThrottleState):
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:
* Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm:
(WebKit::AuxiliaryProcessProxy::notifyPreferencesChanged):
Canonical link: https://commits.webkit.org/277514@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
