Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3c691b824c8ff2b9cda5ca2dc7f1b42ba6881ef3
https://github.com/WebKit/WebKit/commit/3c691b824c8ff2b9cda5ca2dc7f1b42ba6881ef3
Author: Sam Sneddon <[email protected]>
Date: 2024-04-16 (Tue, 16 Apr 2024)
Changed paths:
M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
M Tools/Scripts/webkitpy/port/base.py
Log Message:
-----------
[webkitpy] Refactor SingleTestRunner baseline writing
https://bugs.webkit.org/show_bug.cgi?id=271069
Reviewed by Jonathan Bedard.
Currently we have a bunch of duplicated logic to decide where
SingleTestRunner._save_baseline_data should write; we can in fact
simplify this, with the function only needing to know whether or not
we're rebaselining.
* Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner): Remove unneeded constants.
(SingleTestRunner._add_missing_baselines): Let _save_baseline_data compute
paths.
(SingleTestRunner._location_for_new_baseline): Deleted.
(SingleTestRunner._overwrite_baselines): Let _save_baseline_data compute paths.
(SingleTestRunner._save_baseline_data):
* Tools/Scripts/webkitpy/port/base.py:
(Port.baseline_version_dir): Correctly pass along device_type.
(Port.update_baseline): Deleted.
Canonical link: https://commits.webkit.org/277572@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
