Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 990e1a76ed379729e2bf9eb827e029dcdf00a1d2
      
https://github.com/WebKit/WebKit/commit/990e1a76ed379729e2bf9eb827e029dcdf00a1d2
  Author: Tadeu Zagallo <[email protected]>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AttributeValidator.cpp
    M Source/WebGPU/WGSL/tests/invalid/attribute-validation.wgsl
    M Source/WebGPU/WGSL/tests/invalid/division.wgsl

  Log Message:
  -----------
  [WGSL] Attribute validator asserts on non-overrides
https://bugs.webkit.org/show_bug.cgi?id=272837
rdar://126621130

Reviewed by Mike Wyrzykowski.

In 277194@main I added an assertion that the store type of a variable with an 
@id
attribute must scalar, but that only holds if the variable is an override.

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
* Source/WebGPU/WGSL/tests/invalid/attribute-validation.wgsl:
* Source/WebGPU/WGSL/tests/invalid/division.wgsl:

Canonical link: https://commits.webkit.org/277666@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to