Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c87f99943fbeab08bccf1bb6b3efd601187989a8
https://github.com/WebKit/WebKit/commit/c87f99943fbeab08bccf1bb6b3efd601187989a8
Author: Tyler Wilcock <[email protected]>
Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_label-expected.txt
M
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/accname/name/comp_label-expected.txt
M Source/WebCore/accessibility/AccessibilityMenuListOption.cpp
M Source/WebCore/accessibility/AccessibilityMenuListOption.h
Log Message:
-----------
AX: AccessibilityMenuListOption should subclass AccessibilityNodeObject
https://bugs.webkit.org/show_bug.cgi?id=272840
rdar://126634909
Reviewed by Andres Gonzalez.
AccessibilityMenuListOption is a node object, and the fact that it doesn't
subclass AccessibilityNodeObject
means it's missing important overrides like accessibilityText.
This fixes one subtest in WPT accname/name/comp_label.html, which failed
because option elements didn't
respect aria-label.
*
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_label-expected.txt:
*
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/accname/name/comp_label-expected.txt:
* Source/WebCore/accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
(WebCore::AccessibilityMenuListOption::optionElement const):
(WebCore::AccessibilityMenuListOption::actionElement const):
(WebCore::AccessibilityMenuListOption::isEnabled const):
(WebCore::AccessibilityMenuListOption::isVisible const):
(WebCore::AccessibilityMenuListOption::isSelected const):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::elementRect const):
(WebCore::AccessibilityMenuListOption::stringValue const):
(WebCore::AccessibilityMenuListOption::node const): Deleted.
* Source/WebCore/accessibility/AccessibilityMenuListOption.h:
Canonical link: https://commits.webkit.org/277680@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
