Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e74b50bb809762e861795aa960e7a7f6150c2f8d https://github.com/WebKit/WebKit/commit/e74b50bb809762e861795aa960e7a7f6150c2f8d Author: Sam Sneddon <gsnedd...@apple.com> Date: 2024-04-18 (Thu, 18 Apr 2024)
Changed paths: M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py M Tools/Scripts/webkitpy/layout_tests/models/test_input.py M Tools/Scripts/webkitpy/port/base.py M Tools/Scripts/webkitpy/port/base_unittest.py Log Message: ----------- [webkitpy] SingleTestRunner should use expected paths from Test objects https://bugs.webkit.org/show_bug.cgi?id=271060 Reviewed by Jonathan Bedard. Now LayoutTestFinder is populating the Test object's expectation paths, we should use them in SingleTestRunner. This doesn't migrate the other call sites of Port.expected_filename and Port.expected_baselines to using the Test object's attributes, as these aren't on such commonly used code paths. * Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (TestShard.pack): TestInput.reference_files is gone. * Tools/Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._test_input_for_file): TestInput.reference_files is gone. * Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.__init__): Use Test paths. (SingleTestRunner._reference_files): Ditto. (SingleTestRunner._expected_driver_output): Ditto. (SingleTestRunner._driver_input): Ditto. * Tools/Scripts/webkitpy/layout_tests/models/test_input.py: (TestInput): Remove reference_files, as it is always set to test.reference_files. * Tools/Scripts/webkitpy/port/base.py: (Port.expected_checksum): Deleted. (Port.expected_image): Deleted. (Port.expected_audio): Deleted. (Port.expected_text): Deleted. (Port.reference_files): Deleted. * Tools/Scripts/webkitpy/port/base_unittest.py: (PortTest.test_reference_files): Deleted. (PortTest.test_ref_tests_platform_directory): Deleted. Canonical link: https://commits.webkit.org/277720@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes