Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d94443d3d4bf19b813546e7089bb65f4a00b58c3
https://github.com/WebKit/WebKit/commit/d94443d3d4bf19b813546e7089bb65f4a00b58c3
Author: Megan Gardner <[email protected]>
Date: 2024-04-23 (Tue, 23 Apr 2024)
Changed paths:
M Source/WebCore/PAL/pal/spi/mac/NSTextInputContextSPI.h
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
A Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.h
A Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.mm
A Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.h
A Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
R Source/WebKit/UIProcess/ios/WKTextPlaceholder.h
R Source/WebKit/UIProcess/ios/WKTextPlaceholder.mm
R Source/WebKit/UIProcess/ios/WKTextSelectionRect.h
R Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/TextPlaceholderTests.mm
Log Message:
-----------
Adopt NSTextPlaceholders for Mac.
https://bugs.webkit.org/show_bug.cgi?id=272961
rdar://126696059
Reviewed by Wenson Hsieh.
Adopt NSTextPlaceholders which is a parallel of UITextPlaceholders.
Move the now common code to Cocoa to allow for code sharing.
* Source/WebCore/PAL/pal/spi/mac/NSTextInputContextSPI.h:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView insertTextPlaceholderWithSize:completionHandler:]):
(-[WKWebView removeTextPlaceholder:willInsertText:completionHandler:]):
* Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.h: Renamed from
Source/WebKit/UIProcess/ios/WKTextPlaceholder.h.
* Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.mm: Renamed from
Source/WebKit/UIProcess/ios/WKTextPlaceholder.mm.
(-[WKTextPlaceholder initWithElementContext:]):
(-[WKTextPlaceholder elementContext]):
(-[WKTextPlaceholder rects]):
* Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.h: Renamed from
Source/WebKit/UIProcess/ios/WKTextSelectionRect.h.
* Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.mm: Renamed from
Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm.
(-[WKTextSelectionRectCustomHandleInfo initWithFloatQuad:isHorizontal:]):
(-[WKTextSelectionRectCustomHandleInfo bottomLeft]):
(-[WKTextSelectionRectCustomHandleInfo topLeft]):
(-[WKTextSelectionRectCustomHandleInfo bottomRight]):
(-[WKTextSelectionRectCustomHandleInfo topRight]):
(-[WKTextSelectionRect initWithCGRect:]):
(-[WKTextSelectionRect initWithSelectionGeometry:scaleFactor:]):
(-[WKTextSelectionRect _path]):
(-[WKTextSelectionRect writingDirection]):
(-[WKTextSelectionRect range]):
(-[WKTextSelectionRect _customHandleInfo]):
(-[WKTextSelectionRect rect]):
(-[WKTextSelectionRect containsStart]):
(-[WKTextSelectionRect containsEnd]):
(-[WKTextSelectionRect isVertical]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::insertTextPlaceholder):
(WebKit::WebPageProxy::removeTextPlaceholder):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/AppKitSoftLink.h:
* Source/WebKit/UIProcess/ios/AppKitSoftLink.mm:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::insertTextPlaceholder): Deleted.
(WebKit::WebPageProxy::removeTextPlaceholder): Deleted.
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::insertTextPlaceholderWithSize):
(WebKit::WebViewImpl::removeTextPlaceholder):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::insertTextPlaceholder):
(WebKit::WebPage::removeTextPlaceholder):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::insertTextPlaceholder): Deleted.
(WebKit::WebPage::removeTextPlaceholder): Deleted.
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/TextPlaceholderTests.mm: Added.
Canonical link: https://commits.webkit.org/277879@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
