Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 95019f166e2d4977a3d917d6814b9971acb54def
      
https://github.com/WebKit/WebKit/commit/95019f166e2d4977a3d917d6814b9971acb54def
  Author: Tyler Wilcock <[email protected]>
  Date:   2024-04-23 (Tue, 23 Apr 2024)

  Changed paths:
    M LayoutTests/accessibility/list-detection2-expected.txt
    M LayoutTests/accessibility/list-detection2.html
    M LayoutTests/accessibility/mac/basic-embed-pdf-accessibility-expected.txt
    M LayoutTests/accessibility/mac/basic-embed-pdf-accessibility.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-generic-expected.txt
    M 
LayoutTests/platform/ios/accessibility/changing-aria-hidden-with-display-none-parent-expected.txt
    M 
LayoutTests/platform/ios/accessibility/list-with-dynamically-changing-content-expected.txt
    M 
LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt
    M Source/WebCore/accessibility/AXCoreObject.cpp
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AccessibilityLabel.cpp
    M Source/WebCore/accessibility/AccessibilityList.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilitySVGElement.cpp
    M Source/WebCore/accessibility/AccessibilitySVGRoot.cpp
    M Source/WebCore/accessibility/AccessibilityTree.cpp
    M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
    M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm

  Log Message:
  -----------
  AX: Remove AccessibilityRole::ApplicationGroup and 
AccessibilityRole::ApplicationTextGroup to simplify group logic
https://bugs.webkit.org/show_bug.cgi?id=273089
rdar://126880483

Reviewed by Chris Fleizach.

Currently, there are four "group" roles: Group, ApplicationGroup, TextGroup, 
ApplicationTextGroup. The original intention
for separating these was that the Application style roles were explicitly 
defined by the author (e.g. via role="group"
for ApplicationGroup and role="doc-example" for ApplicationTextGroup), while 
the non-Application variants were implicitly
assigned via heuristics done by the user agent (WebKit).

However, that distinction has become muddied over time:
  1. To support Web Inspector and WPTs, AccessibilityRole::Group has become 
synonymous with "generic" (mostly because we
     used to assign this role to nearly every div on the page). This is 
confusing because it doesn't match or map to
     role="group" (which is AccessibilityRole::ApplicationGroup).
  2. Partially due to point one, in several places we have started returning 
ApplicationGroup even when the element is
     not explicitly assigned as such (i.e. via role="group"), going against the 
point of this role's existence.

With this patch, ApplicationGroup and ApplicationTextGroup are eliminated. Any 
context that needs to know whether an
object has that role due to explicit definition via ARIA can do so by checking 
ariaRoleAttribute(). This makes our code
more clear in several different ways.

This patch fixes two WPT tests and breaks one. The broken will be fixed in a 
follow-up.

* LayoutTests/accessibility/list-detection2-expected.txt:
* LayoutTests/accessibility/list-detection2.html:
* LayoutTests/accessibility/mac/basic-embed-pdf-accessibility-expected.txt:
* LayoutTests/accessibility/mac/basic-embed-pdf-accessibility.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-generic-expected.txt:
* 
LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::isGroup const):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::accessibilityRoleToString):
* Source/WebCore/accessibility/AccessibilityLabel.cpp:
(WebCore::childrenContainOnlyStaticText):
* Source/WebCore/accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::determineAccessibilityRole):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
(WebCore::AccessibilityNodeObject::hierarchicalLevel const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibleNameDerivesFromContent const):
(WebCore::initializeRoleMap):
(WebCore::AccessibilityObject::computedRoleString const):
(WebCore::AccessibilityObject::shouldFocusActiveDescendant const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):
* Source/WebCore/accessibility/AccessibilitySVGElement.cpp:
(WebCore::AccessibilitySVGElement::determineAccessibilityRole):
* Source/WebCore/accessibility/AccessibilitySVGRoot.cpp:
(WebCore::AccessibilitySVGRoot::determineAccessibilityRole):
* Source/WebCore/accessibility/AccessibilityTree.cpp:
(WebCore::AccessibilityTree::determineAccessibilityRole):
* Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::roleIsTextType):
(WebCore::atspiRole):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::subrolePlatformString const):
(WebCore::Accessibility::createPlatformRoleMap):

Canonical link: https://commits.webkit.org/277894@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to